Undefined workspace settings handling #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Unidentified" workspace settings can behave strangely when cycling settings (and especially if dynamic workspaces is used)
Very confusing when cycling settings when we pick from the Meta prefs. Color changes, but name stays the same since the index of the workspace isn't changing. Cycling the Meta prefs in parallel would likely help, but not worth the complexity IMO.
hedning
reviewed
Oct 18, 2019
| @@ -133,6 +149,9 @@ function getNewWorkspaceSettings(index) { | |||
| list.push(uuid); | |||
| workspaceList.set_strv('list', list); | |||
| settings.set_int('index', index); | |||
| settings.set_string('color', getUnusedColor()); | |||
| let n = findWorkspaceSettingsByName(/^Unnamed .*/).length; | |||
| settings.set_string(`Unnamed ${n+1}`) | |||
There was a problem hiding this comment.
Is there anything which prevents us from using Workspace ${i} here?
There was a problem hiding this comment.
No, as long as the list is "monotonic" (which it is atm.) that would also work
There was a problem hiding this comment.
Right, I'd vote for Workspace n in that case, as that makes it clearer that it's a workspace related.
Closed
|
Closing this as #584 addresses this issue - as well as work with dynamic workspaces (and injecting workspaces between other workspaces - e.g. non-monotonic workspace naming). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.