[jvm-run] use target specified jdk when invoking run

[baroquebobcat]

Problem

jvm-run ignores the target specific platform when running a target.

Related #8419

Solution

Use the target platform for distribution lookup instead of using the default. Pass the platform specific args to jvm_options.

Result

The specified jdk is used for execution and the specified jdk's args are used.

[stuhood]

Thanks!

[cosmicexplorer]

Does this close #8419?

[stuhood]

Does this close #8419?

IIRC that was closed by another PR... will resolve.

[stuhood]

There were some test flakes: rebased to rerun.

[stuhood]

@baroquebobcat : It looks like there are some actual test failures in here.

[baroquebobcat]

I'll take a look.

[stuhood]

Sooo. Shoot. It occurred to me that we had discussed renaming test_platform to runtime_platform and using that here (to differentiate the "compilation" platform from the runtime platform used for running or testing).

Is that something you want to do here...?

[baroquebobcat]

Hm. After doing some exploring, I think I want to try and hoist the JvmPlatform references here and other places into JvmTask and maybe drop this. Then I can do the runtime_platform changes in a more constrained way.

[baroquebobcat]

One of the other issues here is that platform isn't a perfect fit for describing which java to run on, since source/target aren't a great abstraction for that. It feels like a stronger relationship between distribution and platform would make sense, or maybe adding more distributiony options to platform would help. eg allowing platforms to declare version ranges.

I don't think this needs to be resolved to support multi-jdk builds, but it would be good to have the configuration here be clearer.