Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jvm-platform] args specified for a jvm platform are not passed to the junit test runner #8419

Closed
baroquebobcat opened this issue Oct 8, 2019 · 1 comment
Closed

[jvm-platform] args specified for a jvm platform are not passed to the junit test runner #8419

baroquebobcat opened this issue Oct 8, 2019 · 1 comment

Comments

@baroquebobcat
Copy link
Contributor

When a test is run with a specific platform, it should use the args provided in the jvm-platforms/platforms configuration. But, those args are not used in that case.

related: #6823
@baroquebobcat baroquebobcat mentioned this issue Oct 8, 2019
Merged
stuhood pushed a commit that referenced this issue Oct 9, 2019
@baroquebobcat @stuhood
[junit-run] apply platform args to junit run java exec (#8421)
abab906 
### Problem
When a test is using a particular jvm platform, it should also use that platform's args. See #8419

### Solution

This patch changes the junit run task to include those args in the jvm_options kwarg passed to execute the test suite.

### Result

The args are now passed to Java.

### Follow on work
I think this isn't the only place with this issue. I found it in jvm run as well.
@baroquebobcat baroquebobcat mentioned this issue Oct 17, 2019
Closed
@stuhood
Copy link
Member

stuhood commented Oct 21, 2019

Resolved by #8421. Thanks!

@stuhood stuhood closed this as completed Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@baroquebobcat @stuhood