Shard testprojects integration tests #4205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirois
approved these changes
Jan 25, 2017
| @@ -4,16 +4,22 @@ | |||
|
|
|||
| from __future__ import (absolute_import, division, generators, nested_scopes, print_function, | |||
| unicode_literals, with_statement) | |||
| import math | |||
There was a problem hiding this comment.
Looks like this needs a blank line above between it and from __future__ ....
This was referenced Jan 25, 2017
kwlzn
approved these changes
Jan 25, 2017
|
LGTM. Alternatively, is there a way to just make a test method for each testproject? |
cheister
approved these changes
Jan 25, 2017
jebbench
added a commit
to jebbench/pants
that referenced
this pull request
Jan 25, 2017
Shard testprojects integration tests (pantsbuild#4205)
lenucksi
pushed a commit
to lenucksi/pants
that referenced
this pull request
Apr 25, 2017
### Problem See pantsbuild#4204: because all tests defined under testprojects are run in a single test method and pytest only outputs anything when a method has completed, travis began failing test runs due to lack of output. Additionally, when this test failed, your only recourse was to run the entire thing. ### Solution Split the test into "select targets to test" and "test them", and then shard the result N ways on a method-by-method basis. In theory this could have been done bash-wise in `ci.sh`... but frankly, I don't want to grow a bash script if I can avoid it. ### Result The test is now sharded `N==8` ways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #4204: because all tests defined under testprojects are run in a single test method and pytest only outputs anything when a method has completed, travis began failing test runs due to lack of output. Additionally, when this test failed, your only recourse was to run the entire thing.
Solution
Split the test into "select targets to test" and "test them", and then shard the result N ways on a method-by-method basis. In theory this could have been done bash-wise in
ci.sh... but frankly, I don't want to grow a bash script if I can avoid it.Result
The test is now sharded
N==8ways.