Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestProjectsIntegrationTest times out frequently under TravisCI #4204

Closed
jsirois opened this issue Jan 24, 2017 · 2 comments
Closed

TestProjectsIntegrationTest times out frequently under TravisCI #4204

jsirois opened this issue Jan 24, 2017 · 2 comments
Assignees
@stuhood

Comments

@jsirois
Copy link
Contributor

jsirois commented Jan 24, 2017

Due to the monolithic nature of TestProjectsIntegrationTest, its two test methods can each take > than the default maximum of 10 minutes TravisCI waits to see console output. This needs to be fixed to remove the travis_wait employed in #4201 as a workaround, and in general for better ability to fine-grain schedule tests.
@jsirois jsirois mentioned this issue Jan 24, 2017
Merged
@jsirois
Copy link
Contributor Author

jsirois commented Jan 24, 2017

Noting that a few tries in #4201 using travis_wait bore no fruit.

@stuhood stuhood self-assigned this Jan 24, 2017
@stuhood stuhood mentioned this issue Jan 25, 2017
Merged
@jsirois
Copy link
Contributor Author

jsirois commented Jan 25, 2017

The fix in #4205 looks like it will cure this.

stuhood pushed a commit that referenced this issue Jan 25, 2017
Shard testprojects integration tests (#4205)
8da8fcf 
### Problem

See #4204: because all tests defined under testprojects are run in a single test method and pytest only outputs anything when a method has completed, travis began failing test runs due to lack of output. Additionally, when this test failed, your only recourse was to run the entire thing.

### Solution

Split the test into "select targets to test" and "test them", and then shard the result N ways on a method-by-method basis. In theory this could have been done bash-wise in `ci.sh`... but frankly, I don't want to grow a bash script if I can avoid it.

### Result

The test is now sharded `N==8` ways.
@stuhood stuhood closed this as completed Jan 25, 2017
@jebbench jebbench mentioned this issue Jan 25, 2017
Merged
lenucksi pushed a commit to lenucksi/pants that referenced this issue Apr 25, 2017
@lenucksi
Shard testprojects integration tests (pantsbuild#4205)
0ab0ad7 
### Problem

See pantsbuild#4204: because all tests defined under testprojects are run in a single test method and pytest only outputs anything when a method has completed, travis began failing test runs due to lack of output. Additionally, when this test failed, your only recourse was to run the entire thing.

### Solution

Split the test into "select targets to test" and "test them", and then shard the result N ways on a method-by-method basis. In theory this could have been done bash-wise in `ci.sh`... but frankly, I don't want to grow a bash script if I can avoid it.

### Result

The test is now sharded `N==8` ways.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuhood stuhood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stuhood @jsirois