Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] Add missing timeout field to target generators #16314

Merged
merged 2 commits into from
Aug 2, 2022
Merged

[internal] Add missing timeout field to target generators #16314

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6be6b46
Add missing timeout field to target generators
alonsodomin Jul 27, 2022
ae923e0
Make test timeout field be a moved field
alonsodomin Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/python/pants/backend/java/target_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,7 @@ class JavaTestsGeneratorSourcesField(JavaGeneratorSourcesField):

class JunitTestsGeneratorTarget(TargetFilesGenerator):
alias = "junit_tests"
core_fields = (
*COMMON_TARGET_FIELDS,
JavaTestsGeneratorSourcesField,
)
core_fields = (*COMMON_TARGET_FIELDS, JavaTestsGeneratorSourcesField, JunitTestTimeoutField)
alonsodomin marked this conversation as resolved.
Show resolved Hide resolved
generated_target_cls = JunitTestTarget
copied_fields = (*COMMON_TARGET_FIELDS, JunitTestTimeoutField)
moved_fields = (
Expand Down
1 change: 1 addition & 0 deletions src/python/pants/backend/kotlin/target_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ class KotlinJunitTestsGeneratorTarget(TargetFilesGenerator):
core_fields = (
*COMMON_TARGET_FIELDS,
KotlinJunitTestsGeneratorSourcesField,
JunitTestTimeoutField,
)
generated_target_cls = KotlinJunitTestTarget
copied_fields = (*COMMON_TARGET_FIELDS, JunitTestTimeoutField)
Expand Down
1 change: 1 addition & 0 deletions src/python/pants/backend/scala/target_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ class ScalatestTestsGeneratorTarget(TargetFilesGenerator):
*COMMON_TARGET_FIELDS,
ScalatestTestsGeneratorSourcesField,
ScalatestTestsSourcesOverridesField,
ScalatestTestTimeoutField,
)
generated_target_cls = ScalatestTestTarget
copied_fields = (*COMMON_TARGET_FIELDS, ScalatestTestTimeoutField)
Expand Down