Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[internal] Add missing timeout field to target generators #16314

Merged
merged 2 commits into from
Aug 2, 2022
Merged

[internal] Add missing timeout field to target generators #16314

merged 2 commits into from
Aug 2, 2022

Conversation

alonsodomin
Copy link
Contributor

The PR #16126 was missing adding the test timeout fields to the core_fields class var in the target generators.

@alonsodomin alonsodomin added the category:bugfix Bug fixes for released features label Jul 27, 2022
@alonsodomin alonsodomin requested review from stuhood and tdyas July 27, 2022 08:15
@stuhood stuhood enabled auto-merge (squash) August 2, 2022 15:09
@stuhood
Copy link
Member

stuhood commented Aug 2, 2022

@alonsodomin : This one is marked needs-cherrypick (without a Milestone, but presumably you meant 2.13.x). But it looks like #16126 was not cherry-picked to 2.13.x either: do you need both of them picked?

@stuhood stuhood added this to the 2.13.x milestone Aug 2, 2022
@stuhood stuhood merged commit ea46136 into pantsbuild:main Aug 2, 2022
stuhood pushed a commit to stuhood/pants that referenced this pull request Aug 2, 2022
@alonsodomin @stuhood
[internal] Add missing timeout field to target generators (pantsbuild…
7dc920b 
…#16314)

The PR pantsbuild#16126 was missing adding the test timeout fields to the `core_fields` class var in the target generators.

[ci skip-rust]
[ci skip-build-wheels]
@stuhood stuhood mentioned this pull request Aug 2, 2022
Closed
cczona pushed a commit to cczona/pants that referenced this pull request Sep 1, 2022
@alonsodomin @cczona
[internal] Add missing timeout field to target generators (pantsbuild…
96ec5fc 
…#16314)

The PR pantsbuild#16126 was missing adding the test timeout fields to the `core_fields` class var in the target generators.

[ci skip-rust]
[ci skip-build-wheels]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuhood stuhood stuhood left review comments

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

@tdyas tdyas tdyas approved these changes

Assignees
No one assigned
Labels
category:bugfix Bug fixes for released features
Projects
None yet
Milestone
2.13.x
Development

Successfully merging this pull request may close these issues.
4 participants
@alonsodomin @stuhood @tdyas @Eric-Arellano