Add support for InteractiveProcess consuming inputs while run_in_workspace=True
#16093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
force-pushed
the
stuhood/interactive-process-uses-prepare-workdir
branch
2 times, most recently
from
bd92f4b to
530bd42
Compare
stuhood
force-pushed
the
stuhood/interactive-process-uses-prepare-workdir
branch
from
530bd42 to
7906af5
Compare
stuhood
changed the title
InteractiveProcess uses prepare_workdirInteractiveProcess consuming inputs while run_in_workspace=True
stuhood
added
category:bugfix
stuhood
force-pushed
the
stuhood/interactive-process-uses-prepare-workdir
branch
from
7906af5 to
a93fc66
Compare
|
Commits are useful to review independently. |
|
I can confirm this fixes #15771 |
[ci skip-build-wheels]
[ci skip-build-wheels]
…uest`. [ci skip-build-wheels]
[ci skip-build-wheels]
# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
…hroots. [ci skip-rust] [ci skip-build-wheels]
stuhood
force-pushed
the
stuhood/interactive-process-uses-prepare-workdir
branch
from
a93fc66 to
8557cd0
Compare
benjyw
approved these changes
Jul 12, 2022
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Jul 12, 2022
…orkspace=True` (pantsbuild#16093) As described in pantsbuild#16105, blocking code in `@rule` bodies can trigger a shutdown race condition when `pantsd` is disabled and `Ctrl+C` is sent. Longer term solutions are discussed on that issue, but in the short term, we can avoid using blocking code for `InteractiveProcess`, such that `run` uses the same sandbox creation, async teardown, and relativizing code as `Process` does. Fixes pantsbuild#13852, fixes pantsbuild#14386, fixes pantsbuild#16120, and fixes pantsbuild#15771. [ci skip-build-wheels]
stuhood
added a commit
that referenced
this pull request
Jul 12, 2022
stuhood
added a commit
that referenced
this pull request
Jul 12, 2022
…orkspace=True` (Cherry-pick of #16093) (#16148) As described in #16105, blocking code in `@rule` bodies can trigger a shutdown race condition when `pantsd` is disabled and `Ctrl+C` is sent. Longer term solutions are discussed on that issue, but in the short term, we can avoid using blocking code for `InteractiveProcess`, such that `run` uses the same sandbox creation, async teardown, and relativizing code as `Process` does. Fixes #13852, fixes #14386, fixes #16120, and fixes #15771.
Merged
jyggen
pushed a commit
to jyggen/pants
that referenced
this pull request
Jul 27, 2022
…antsbuild#16273) This replaces the hacky `__RuntimeJvm` construct with `InteractiveProcess`' support for `immutable_inputs` and `append_only_caches` that was added in pantsbuild#16093. This required adding passthrough args to `RunRequest`. Closes pantsbuild#16104 and removes a Terrible Terrible Hack. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
pushed a commit
to stuhood/pants
that referenced
this pull request
Aug 2, 2022
…antsbuild#16273) This replaces the hacky `__RuntimeJvm` construct with `InteractiveProcess`' support for `immutable_inputs` and `append_only_caches` that was added in pantsbuild#16093. This required adding passthrough args to `RunRequest`. Closes pantsbuild#16104 and removes a Terrible Terrible Hack. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
pushed a commit
to stuhood/pants
that referenced
this pull request
Aug 2, 2022
…antsbuild#16273) This replaces the hacky `__RuntimeJvm` construct with `InteractiveProcess`' support for `immutable_inputs` and `append_only_caches` that was added in pantsbuild#16093. This required adding passthrough args to `RunRequest`. Closes pantsbuild#16104 and removes a Terrible Terrible Hack. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
added a commit
that referenced
this pull request
Aug 2, 2022
…herry-pick of #16273) (#16370) This replaces the hacky `__RuntimeJvm` construct with `InteractiveProcess`' support for `immutable_inputs` and `append_only_caches` that was added in #16093. This required adding passthrough args to `RunRequest`. Closes #16104 and removes a Terrible Terrible Hack. [ci skip-rust] [ci skip-build-wheels] Co-authored-by: Christopher Neugebauer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #16105, blocking code in
@rulebodies can trigger a shutdown race condition whenpantsdis disabled andCtrl+Cis sent.Longer term solutions are discussed on that issue, but in the short term, we can avoid using blocking code for
InteractiveProcess, such thatrunuses the same sandbox creation, async teardown, and relativizing code asProcessdoes.Fixes #13852, fixes #14386, fixes #16120, and fixes #15771.