Consider adding a native relocatable-Process/InteractiveProcess facility to ease run implementations
#14386
Assignees
Comments
This was referenced Feb 7, 2022
|
#15340 added support for templating |
stuhood
added a commit
that referenced
this issue
Jul 12, 2022
…orkspace=True` (#16093) As described in #16105, blocking code in `@rule` bodies can trigger a shutdown race condition when `pantsd` is disabled and `Ctrl+C` is sent. Longer term solutions are discussed on that issue, but in the short term, we can avoid using blocking code for `InteractiveProcess`, such that `run` uses the same sandbox creation, async teardown, and relativizing code as `Process` does. Fixes #13852, fixes #14386, fixes #16120, and fixes #15771.
stuhood
added a commit
to stuhood/pants
that referenced
this issue
Jul 12, 2022
…orkspace=True` (pantsbuild#16093) As described in pantsbuild#16105, blocking code in `@rule` bodies can trigger a shutdown race condition when `pantsd` is disabled and `Ctrl+C` is sent. Longer term solutions are discussed on that issue, but in the short term, we can avoid using blocking code for `InteractiveProcess`, such that `run` uses the same sandbox creation, async teardown, and relativizing code as `Process` does. Fixes pantsbuild#13852, fixes pantsbuild#14386, fixes pantsbuild#16120, and fixes pantsbuild#15771. [ci skip-build-wheels]
stuhood
added a commit
that referenced
this issue
Jul 12, 2022
…orkspace=True` (Cherry-pick of #16093) (#16148) As described in #16105, blocking code in `@rule` bodies can trigger a shutdown race condition when `pantsd` is disabled and `Ctrl+C` is sent. Longer term solutions are discussed on that issue, but in the short term, we can avoid using blocking code for `InteractiveProcess`, such that `run` uses the same sandbox creation, async teardown, and relativizing code as `Process` does. Fixes #13852, fixes #14386, fixes #16120, and fixes #15771.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When we
runanInteractiveProcess, all use of relative paths in any inputProcessdefinition must be converted to absolute usage in order to allow thecwdof the process to be different (usually, the build root) from the sandbox directory containing its inputs (usually a temporary directory). But we don't currently have any explicit support for this, and so Python and the JVM each have slightly different solutions (#14352 and the PEX venv script).Native support for this might look like adding a well-known env var and template variable for args, which the
InteractiveProcessrunner would fill with an absolute path, and which theProcessrunner(s) would define/template to be empty.The text was updated successfully, but these errors were encountered: