Fix tag filtering with --changed-dependees
#15546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
added
needs-cherrypick
category:bugfix
stuhood
reviewed
May 19, 2022
| # If `--changed-dependees` is used, we cannot eagerly filter out root targets. We | ||
| # need to first find their dependees, and only then should we filter. See | ||
| # https://github.com/pantsbuild/pants/issues/15544 | ||
| filter_by_global_options=no_dependees, |
There was a problem hiding this comment.
Should this be using bool(specs_filter) instead, in order to ensure that regexes are applied as well?
There was a problem hiding this comment.
Regexes will be applied via the last part of this rule -- no_dependees only determines whether we eagerly filter with the roots, or defer the filtering until after dependees have been found
Eric-Arellano
added a commit
that referenced
this pull request
May 20, 2022
Revert #15413. It did fix two bugs, but was too risky. In particular, it resulted in #15544. I wasn't able to cherry-pick the fix #15546 because the tests have diverged too much. So instead, we should revert. However, we keep the fix for `python_tests`, which was a 2.11-specific regression. [ci skip-rust]
Eric-Arellano
added a commit
to Eric-Arellano/pants
that referenced
this pull request
May 20, 2022
Closes pantsbuild#15544. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15544.
[ci skip-rust]
[ci skip-build-wheels]