v2.11.1rc0 changed behavior of filter when filtering on transitive changed-since AND tags

[danxmoran]

Describe the bug

Setup

app/
    pants
    pants.toml
    BUILD.pants
    Dockerfile
    entrypoint.sh

pants generated with:

curl -L -O https://static.pantsbuild.org/setup/pants && chmod +x ./pants

In pants.toml:

[GLOBAL]
pants_version = "2.11.0"
backend_packages = [
    "pants.backend.shell",
    "pants.backend.docker",
]

In BUILD.pants:

shell_source(name="entrypoint", source="entrypoint.sh")
docker_image(name="docker", dependencies=[":entrypoint"], tags=["buildme"])

In Dockerfile:

FROM ubuntu:20.04

COPY ./entrypoint.sh .

ENTRYPOINT ["/entrypoint.sh"]

In entrypoint.sh:

#!/usr/bin/env bash

echo "${@}"

Commit these contents as an initial commit:

git init .
git add .
git commit -m "Initial commit"

The Bug

Update entrypoint.sh:

echo 'exec "${@}"' >> entrypoint.sh

In Pants v2.11.0, running:

./pants --changed-dependees=transitive --changed-since=$(git rev-parse HEAD) --tag=buildme \
    filter --target-type=docker_image

Outputs //:docker.

If you upgrade to Pants v2.11.1rc0, the command no longer outputs //:docker:

# (Using the SHA of v2.11.1rc0 for an easier demo)
PANTS_SHA=9f9dfa58e8744d51c49316dccc14d3667c07ed04 ./pants \
    --changed-dependees=transitive --changed-since=$(git rev-parse HEAD) --tag=buildme \
    filter --target-type=docker_image

Bisecting the commits between v2.11.0 and v2.11.1rc0 shows that fcaac98 is where the behavior changed:

# Commit before the change, prints '//:docker'
PANTS_SHA=88b73ee0712928d1a63796907ab2924fe721bff6 ./pants \
    --changed-dependees=transitive --changed-since=$(git rev-parse HEAD) --tag=buildme \
    filter --target-type=docker_image

# Behavior change, doesn't print '//:docker'
PANTS_SHA=fcaac9840256ac52b57b3dc2281d07a6b1e02455 ./pants \
    --changed-dependees=transitive --changed-since=$(git rev-parse HEAD) --tag=buildme \
    filter --target-type=docker_image

Pants version
2.11.x

OS
Observed in both MacOS and Linux