Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename PexInterpreterConstraints to InterpreterConstraints and move to dedicated file #12021

Merged
merged 3 commits into from
May 6, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/python/pants/backend/awslambda/python/rules.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
ResolvePythonAwsHandlerRequest,
)
from pants.backend.python.util_rules import pex_from_targets
from pants.backend.python.util_rules.interpreter_constraints import InterpreterConstraints
from pants.backend.python.util_rules.pex import (
PexInterpreterConstraints,
PexPlatforms,
PexRequest,
PexRequirements,
Expand Down Expand Up @@ -96,7 +96,7 @@ async def package_python_awslambda(
output_filename="lambdex.pex",
internal_only=True,
requirements=PexRequirements(lambdex.all_requirements),
interpreter_constraints=PexInterpreterConstraints(lambdex.interpreter_constraints),
interpreter_constraints=InterpreterConstraints(lambdex.interpreter_constraints),
main=lambdex.main,
)

Expand Down
4 changes: 2 additions & 2 deletions src/python/pants/backend/codegen/protobuf/python/rules.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
from pants.backend.codegen.protobuf.target_types import ProtobufGrpcToggle, ProtobufSources
from pants.backend.python.target_types import PythonSources
from pants.backend.python.util_rules import pex
from pants.backend.python.util_rules.interpreter_constraints import InterpreterConstraints
from pants.backend.python.util_rules.pex import (
PexInterpreterConstraints,
PexRequest,
PexRequirements,
PexResolveInfo,
Expand Down Expand Up @@ -109,7 +109,7 @@ async def generate_python_from_protobuf(
output_filename="mypy_protobuf.pex",
internal_only=True,
requirements=PexRequirements([python_protobuf_mypy_plugin.requirement]),
interpreter_constraints=PexInterpreterConstraints(
interpreter_constraints=InterpreterConstraints(
python_protobuf_mypy_plugin.interpreter_constraints
),
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

from dataclasses import dataclass

from pants.backend.python.util_rules.pex import PexInterpreterConstraints
from pants.backend.python.util_rules.interpreter_constraints import InterpreterConstraints
from pants.backend.python.util_rules.pex_environment import PythonExecutable
from pants.core.util_rules.source_files import SourceFilesRequest
from pants.core.util_rules.stripped_source_files import StrippedSourceFiles
Expand Down Expand Up @@ -143,14 +143,14 @@ class ParsedPythonImports(DeduplicatedCollection[str]):
@dataclass(frozen=True)
class ParsePythonImportsRequest:
sources: Sources
interpreter_constraints: PexInterpreterConstraints
interpreter_constraints: InterpreterConstraints
string_imports: bool


@rule
async def parse_python_imports(request: ParsePythonImportsRequest) -> ParsedPythonImports:
python_interpreter, script_digest, stripped_sources = await MultiGet(
Get(PythonExecutable, PexInterpreterConstraints, request.interpreter_constraints),
Get(PythonExecutable, InterpreterConstraints, request.interpreter_constraints),
Get(Digest, CreateDigest([FileContent("__parse_python_imports.py", _SCRIPT.encode())])),
Get(StrippedSourceFiles, SourceFilesRequest([request.sources])),
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
)
from pants.backend.python.target_types import PythonLibrary, PythonSources
from pants.backend.python.util_rules import pex
from pants.backend.python.util_rules.pex import PexInterpreterConstraints
from pants.backend.python.util_rules.interpreter_constraints import InterpreterConstraints
from pants.core.util_rules import stripped_source_files
from pants.engine.addresses import Address
from pants.testutil.python_interpreter_selection import (
Expand Down Expand Up @@ -58,7 +58,7 @@ def assert_imports_parsed(
[
ParsePythonImportsRequest(
tgt[PythonSources],
PexInterpreterConstraints([constraints]),
InterpreterConstraints([constraints]),
string_imports=string_imports,
)
],
Expand Down
4 changes: 2 additions & 2 deletions src/python/pants/backend/python/dependency_inference/rules.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
from pants.backend.python.target_types import PythonSources, PythonTestsSources
from pants.backend.python.util_rules import ancestor_files, pex
from pants.backend.python.util_rules.ancestor_files import AncestorFiles, AncestorFilesRequest
from pants.backend.python.util_rules.pex import PexInterpreterConstraints
from pants.backend.python.util_rules.interpreter_constraints import InterpreterConstraints
from pants.core.util_rules import stripped_source_files
from pants.engine.addresses import Address
from pants.engine.internals.graph import Owners, OwnersRequest
Expand Down Expand Up @@ -138,7 +138,7 @@ async def infer_python_dependencies_via_imports(
ParsedPythonImports,
ParsePythonImportsRequest(
request.sources_field,
PexInterpreterConstraints.create_from_targets([wrapped_tgt.target], python_setup),
InterpreterConstraints.create_from_targets([wrapped_tgt.target], python_setup),
string_imports=python_infer_subsystem.string_imports,
),
),
Expand Down
11 changes: 3 additions & 8 deletions src/python/pants/backend/python/goals/coverage_py.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,8 @@

from pants.backend.python.subsystems.python_tool_base import PythonToolBase
from pants.backend.python.target_types import ConsoleScript
from pants.backend.python.util_rules.pex import (
PexInterpreterConstraints,
PexRequest,
PexRequirements,
VenvPex,
VenvPexProcess,
)
from pants.backend.python.util_rules.interpreter_constraints import InterpreterConstraints
from pants.backend.python.util_rules.pex import PexRequest, PexRequirements, VenvPex, VenvPexProcess
from pants.backend.python.util_rules.python_sources import (
PythonSourceFiles,
PythonSourceFilesRequest,
Expand Down Expand Up @@ -306,7 +301,7 @@ async def setup_coverage(coverage: CoverageSubsystem) -> CoverageSetup:
output_filename="coverage.pex",
internal_only=True,
requirements=PexRequirements(coverage.all_requirements),
interpreter_constraints=PexInterpreterConstraints(coverage.interpreter_constraints),
interpreter_constraints=InterpreterConstraints(coverage.interpreter_constraints),
main=coverage.main,
),
)
Expand Down
6 changes: 2 additions & 4 deletions src/python/pants/backend/python/goals/pytest_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@
PythonTestsSources,
PythonTestsTimeout,
)
from pants.backend.python.util_rules.interpreter_constraints import InterpreterConstraints
from pants.backend.python.util_rules.pex import (
Pex,
PexInterpreterConstraints,
PexRequest,
PexRequirements,
VenvPex,
Expand Down Expand Up @@ -128,9 +128,7 @@ async def setup_pytest_for_target(
)
all_targets = transitive_targets.closure

interpreter_constraints = PexInterpreterConstraints.create_from_targets(
all_targets, python_setup
)
interpreter_constraints = InterpreterConstraints.create_from_targets(all_targets, python_setup)

requirements_pex_get = Get(
Pex,
Expand Down
13 changes: 4 additions & 9 deletions src/python/pants/backend/python/goals/setup_py.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,8 @@
ResolvePexEntryPointRequest,
SetupPyCommandsField,
)
from pants.backend.python.util_rules.pex import (
PexInterpreterConstraints,
PexRequest,
PexRequirements,
VenvPex,
VenvPexProcess,
)
from pants.backend.python.util_rules.interpreter_constraints import InterpreterConstraints
from pants.backend.python.util_rules.pex import PexRequest, PexRequirements, VenvPex, VenvPexProcess
from pants.backend.python.util_rules.python_sources import (
PythonSourceFilesRequest,
StrippedPythonSourceFiles,
Expand Down Expand Up @@ -290,7 +285,7 @@ class RunSetupPyRequest:
"""A request to run a setup.py command."""

exported_target: ExportedTarget
interpreter_constraints: PexInterpreterConstraints
interpreter_constraints: InterpreterConstraints
chroot: SetupPyChroot
args: Tuple[str, ...]

Expand Down Expand Up @@ -365,7 +360,7 @@ async def package_python_dist(
) -> BuiltPackage:
transitive_targets = await Get(TransitiveTargets, TransitiveTargetsRequest([field_set.address]))
exported_target = ExportedTarget(transitive_targets.roots[0])
interpreter_constraints = PexInterpreterConstraints.create_from_targets(
interpreter_constraints = InterpreterConstraints.create_from_targets(
transitive_targets.closure, python_setup
)
chroot = await Get(
Expand Down
13 changes: 4 additions & 9 deletions src/python/pants/backend/python/lint/bandit/rules.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,8 @@
from pants.backend.python.lint.bandit.subsystem import Bandit
from pants.backend.python.target_types import InterpreterConstraintsField, PythonSources
from pants.backend.python.util_rules import pex
from pants.backend.python.util_rules.pex import (
PexInterpreterConstraints,
PexRequest,
PexRequirements,
VenvPex,
VenvPexProcess,
)
from pants.backend.python.util_rules.interpreter_constraints import InterpreterConstraints
from pants.backend.python.util_rules.pex import PexRequest, PexRequirements, VenvPex, VenvPexProcess
from pants.core.goals.lint import LintReport, LintRequest, LintResult, LintResults, LintSubsystem
from pants.core.util_rules.config_files import ConfigFiles, ConfigFilesRequest
from pants.core.util_rules.source_files import SourceFiles, SourceFilesRequest
Expand Down Expand Up @@ -47,7 +42,7 @@ class BanditRequest(LintRequest):
@dataclass(frozen=True)
class BanditPartition:
field_sets: Tuple[BanditFieldSet, ...]
interpreter_constraints: PexInterpreterConstraints
interpreter_constraints: InterpreterConstraints


def generate_argv(
Expand Down Expand Up @@ -138,7 +133,7 @@ async def bandit_lint(
# ( https://github.com/PyCQA/bandit#under-which-version-of-python-should-i-install-bandit). We
# batch targets by their constraints to ensure, for example, that all Python 2 targets run
# together and all Python 3 targets run together.
constraints_to_field_sets = PexInterpreterConstraints.group_field_sets_by_constraints(
constraints_to_field_sets = InterpreterConstraints.group_field_sets_by_constraints(
request.field_sets, python_setup
)
partitioned_results = await MultiGet(
Expand Down
13 changes: 4 additions & 9 deletions src/python/pants/backend/python/lint/black/rules.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,8 @@
from pants.backend.python.lint.python_fmt import PythonFmtRequest
from pants.backend.python.target_types import InterpreterConstraintsField, PythonSources
from pants.backend.python.util_rules import pex
from pants.backend.python.util_rules.pex import (
PexInterpreterConstraints,
PexRequest,
PexRequirements,
VenvPex,
VenvPexProcess,
)
from pants.backend.python.util_rules.interpreter_constraints import InterpreterConstraints
from pants.backend.python.util_rules.pex import PexRequest, PexRequirements, VenvPex, VenvPexProcess
from pants.core.goals.fmt import FmtResult
from pants.core.goals.lint import LintRequest, LintResult, LintResults
from pants.core.util_rules.config_files import ConfigFiles, ConfigFilesRequest
Expand Down Expand Up @@ -78,7 +73,7 @@ async def setup_black(
# when relevant. We only do this if if <3.8 can't be used, as we don't want a loose requirement
# like `>=3.6` to result in requiring Python 3.8, which would error if 3.8 is not installed on
# the machine.
all_interpreter_constraints = PexInterpreterConstraints.create_from_compatibility_fields(
all_interpreter_constraints = InterpreterConstraints.create_from_compatibility_fields(
(field_set.interpreter_constraints for field_set in setup_request.request.field_sets),
python_setup,
)
Expand All @@ -88,7 +83,7 @@ async def setup_black(
all_interpreter_constraints.requires_python38_or_newer()
and black.options.is_default("interpreter_constraints")
)
else PexInterpreterConstraints(black.interpreter_constraints)
else InterpreterConstraints(black.interpreter_constraints)
)

black_pex_get = Get(
Expand Down
11 changes: 3 additions & 8 deletions src/python/pants/backend/python/lint/docformatter/rules.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,8 @@
from pants.backend.python.lint.python_fmt import PythonFmtRequest
from pants.backend.python.target_types import PythonSources
from pants.backend.python.util_rules import pex
from pants.backend.python.util_rules.pex import (
PexInterpreterConstraints,
PexRequest,
PexRequirements,
VenvPex,
VenvPexProcess,
)
from pants.backend.python.util_rules.interpreter_constraints import InterpreterConstraints
from pants.backend.python.util_rules.pex import PexRequest, PexRequirements, VenvPex, VenvPexProcess
from pants.core.goals.fmt import FmtResult
from pants.core.goals.lint import LintRequest, LintResult, LintResults
from pants.core.util_rules.source_files import SourceFiles, SourceFilesRequest
Expand Down Expand Up @@ -69,7 +64,7 @@ async def setup_docformatter(setup_request: SetupRequest, docformatter: Docforma
output_filename="docformatter.pex",
internal_only=True,
requirements=PexRequirements(docformatter.all_requirements),
interpreter_constraints=PexInterpreterConstraints(docformatter.interpreter_constraints),
interpreter_constraints=InterpreterConstraints(docformatter.interpreter_constraints),
main=docformatter.main,
),
)
Expand Down
13 changes: 4 additions & 9 deletions src/python/pants/backend/python/lint/flake8/rules.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,8 @@
from pants.backend.python.lint.flake8.subsystem import Flake8
from pants.backend.python.target_types import InterpreterConstraintsField, PythonSources
from pants.backend.python.util_rules import pex
from pants.backend.python.util_rules.pex import (
PexInterpreterConstraints,
PexRequest,
PexRequirements,
VenvPex,
VenvPexProcess,
)
from pants.backend.python.util_rules.interpreter_constraints import InterpreterConstraints
from pants.backend.python.util_rules.pex import PexRequest, PexRequirements, VenvPex, VenvPexProcess
from pants.core.goals.lint import LintReport, LintRequest, LintResult, LintResults, LintSubsystem
from pants.core.util_rules.config_files import ConfigFiles, ConfigFilesRequest
from pants.core.util_rules.source_files import SourceFiles, SourceFilesRequest
Expand Down Expand Up @@ -47,7 +42,7 @@ class Flake8Request(LintRequest):
@dataclass(frozen=True)
class Flake8Partition:
field_sets: Tuple[Flake8FieldSet, ...]
interpreter_constraints: PexInterpreterConstraints
interpreter_constraints: InterpreterConstraints


def generate_argv(
Expand Down Expand Up @@ -136,7 +131,7 @@ async def flake8_lint(
# (http://flake8.pycqa.org/en/latest/user/invocation.html). We batch targets by their
# constraints to ensure, for example, that all Python 2 targets run together and all Python 3
# targets run together.
constraints_to_field_sets = PexInterpreterConstraints.group_field_sets_by_constraints(
constraints_to_field_sets = InterpreterConstraints.group_field_sets_by_constraints(
request.field_sets, python_setup
)
partitioned_results = await MultiGet(
Expand Down
4 changes: 2 additions & 2 deletions src/python/pants/backend/python/lint/isort/rules.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
from pants.backend.python.lint.python_fmt import PythonFmtRequest
from pants.backend.python.target_types import PythonSources
from pants.backend.python.util_rules import pex
from pants.backend.python.util_rules.interpreter_constraints import InterpreterConstraints
from pants.backend.python.util_rules.pex import (
PexInterpreterConstraints,
PexRequest,
PexRequirements,
PexResolveInfo,
Expand Down Expand Up @@ -90,7 +90,7 @@ async def setup_isort(setup_request: SetupRequest, isort: Isort) -> Setup:
output_filename="isort.pex",
internal_only=True,
requirements=PexRequirements(isort.all_requirements),
interpreter_constraints=PexInterpreterConstraints(isort.interpreter_constraints),
interpreter_constraints=InterpreterConstraints(isort.interpreter_constraints),
main=isort.main,
),
)
Expand Down
8 changes: 4 additions & 4 deletions src/python/pants/backend/python/lint/pylint/rules.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@
PythonSources,
)
from pants.backend.python.util_rules import pex_from_targets
from pants.backend.python.util_rules.interpreter_constraints import InterpreterConstraints
from pants.backend.python.util_rules.pex import (
Pex,
PexInterpreterConstraints,
PexRequest,
PexRequirements,
VenvPex,
Expand Down Expand Up @@ -73,13 +73,13 @@ class PylintTargetSetup:
class PylintPartition:
field_sets: Tuple[PylintFieldSet, ...]
targets_with_dependencies: Targets
interpreter_constraints: PexInterpreterConstraints
interpreter_constraints: InterpreterConstraints
plugin_targets: Targets

def __init__(
self,
target_setups: Iterable[PylintTargetSetup],
interpreter_constraints: PexInterpreterConstraints,
interpreter_constraints: InterpreterConstraints,
plugin_targets: Iterable[Target],
) -> None:
field_sets = []
Expand Down Expand Up @@ -261,7 +261,7 @@ async def pylint_lint(
request.field_sets, linted_targets, per_target_dependencies
):
target_setup = PylintTargetSetup(field_set, Targets([tgt, *dependencies]))
interpreter_constraints = PexInterpreterConstraints.create_from_compatibility_fields(
interpreter_constraints = InterpreterConstraints.create_from_compatibility_fields(
(
*(
tgt[InterpreterConstraintsField]
Expand Down
Loading