Rename PexInterpreterConstraints to InterpreterConstraints and move to dedicated file
#12021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve to dedicated file
|
Interpreter constraints are absolutely Pex specific. The LHS syntax (PyPy or CPython) in particular is only understood by Pex. I have not read this PR, but it appears fully justified by other legitimate reasons you lay out. Consider dropping this false justification from the description to avoid lessening the power of your argument. |
tdyas
approved these changes
May 6, 2021
…aints # Conflicts: # src/python/pants/backend/python/util_rules/pex.py # src/python/pants/backend/python/util_rules/pex_test.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pex.pywas already way too big and will keep getting bigger as we add per-tool lockfiles (https://docs.google.com/document/d/1bCYb0UQZx9a-9tAagydCN_z3826QRvz_3aVnXKSNTJw/edit#).