Remove support for "weak" Gets #10805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
approved these changes
Sep 17, 2020
There was a problem hiding this comment.
Thanks for cleaning this up! I updated the PR description to close out #10394.
This reverts commit 0ad3a56. [ci skip-build-wheels]
stuhood
force-pushed
the
stuhood/revert-weak-gets
branch
from
5b23433 to
1451ddd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
"weak"
Gets were a potential solution for optionally allowing for cycles in the runtimeGraph, but they were only partially implemented (see #10229), and not particularly trustworthy. We ended up going with a higher level solution in #10409, but the weak-Gets code still exists, and increases the complexity of thegraphcrate unnecessarily.Solution
Revert #10230. Closes #10229 and closes #10394.
[ci skip-build-wheels]