Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove weak Gets #10394

Closed
Eric-Arellano opened this issue Jul 17, 2020 · 0 comments · Fixed by #10805
Closed

Remove weak Gets #10394

Eric-Arellano opened this issue Jul 17, 2020 · 0 comments · Fixed by #10805

Comments

@Eric-Arellano
Copy link
Contributor

Eric-Arellano commented Jul 17, 2020 •
edited
Loading

This ended up not being as robust as we wanted. Now it's leftover code.
@Eric-Arellano Eric-Arellano changed the title Teach MyPy that weak gets are Optional Remove weak Gets Sep 10, 2020
@Eric-Arellano Eric-Arellano mentioned this issue Sep 17, 2020
Merged
stuhood added a commit that referenced this issue Sep 17, 2020
@stuhood
Remove support for "weak" Gets (#10805)
3b70039 
### Problem

"weak" `Get`s were a potential solution for optionally allowing for cycles in the runtime `Graph`, but they were only partially implemented (see #10229), and not particularly trustworthy. We ended up going with a higher level solution in #10409, but the weak-`Get`s code still exists, and increases the complexity of the `graph` crate unnecessarily.

### Solution

Revert #10230. Closes #10229 and closes #10394.

[ci skip-build-wheels]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove support for "weak" Gets stuhood/pants
1 participant
@Eric-Arellano