Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix on GUI import #244

Merged
merged 4 commits into from
Jan 13, 2017
Merged

Bug fix on GUI import #244

merged 4 commits into from
Jan 13, 2017

Conversation

wisechengyi
Copy link
Collaborator

@wisechengyi wisechengyi commented Jan 13, 2017 •
edited
Loading

  • Fix a bug in finding pants executable
  • Move error handling to the appropriate method that throws configuration exceptions, so IntelliJ will display a nice GUI for any import issue instead of treating it as an exception.

@wisechengyi wisechengyi merged commit 4de66e1 into pantsbuild:master Jan 13, 2017
@wisechengyi wisechengyi mentioned this pull request Jan 14, 2017
Merged
wisechengyi added a commit that referenced this pull request Jan 15, 2017
@wisechengyi
Release 1.5.2 (#248)
4383994 
* Add usage logging extension point (#239)
* GUI import fix (#244)
* Move Pants output to console view instead of notification channel (#242)
@wisechengyi wisechengyi deleted the error_handling branch July 31, 2017 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
reviewable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wisechengyi