Move Pants output to console view instead of notification channel #242

wisechengyi · 2017-01-10T07:18:28Z

Problem

Pants output used to go out via the IntelliJ notification channel with a few down sides:

No auto scrolling supported. If the message gets long, user has to manually scroll the message window.
Output does not show up exactly like the command line. E.g. compile error indicator ^ will show up off.
Cannot take advantage of IntelliJ hyperlink for user to click on the error to directly dump to what the error stems.

Solution

Use a text console view, which has

Auto scroll by default
Correct output format
Capability to inject hyperlinks

This reverts commit b152ade.

peiyuwang · 2017-01-13T19:50:09Z

tests/com/twitter/intellij/pants/execution/PantsMakeMessageTest.java

+  }
+
+
+  public void testErrorMessageWithLocation2() {


what's the difference from the java test case? seems redundant

Thanks! I will remove having certain file extensions as a requirement, because eventually we will check if it is a valid file path when constructing the hyperlink.

peiyuwang · 2017-01-13T19:55:13Z

src/com/twitter/intellij/pants/execution/PantsMakeBeforeRun.java

+
+    try {
+      // filePath path is between tag and first colon
+      String filePath = splitByColon[0].substring(splitByColon[0].indexOf(tag) + tag.length()).trim();


some negative examples from old log

[error] Compile failed at Dec 9, 2016 6:33:30 AM [0.080s] [error] Assert.assertEquals("0:00:00.000", ManagementUtils.getAverageAge(d0));

It's okay for String filePath to be Assert.assertEquals("0 for example, because the hyperlink construction will check if it is an actual file. If not, it will there will be no hyperlinks.

I will add more doc to this to be more clear.

More doc added, as well as test case to cover this.

peiyuwang · 2017-01-13T21:33:56Z

src/com/twitter/intellij/pants/execution/PantsMakeBeforeRun.java

+          OpenFileHyperlinkInfo linkInfo = new OpenFileHyperlinkInfo(
+            project,
+            result.get().getFile(),
+            result.get().lineNumber - 1, // line number needs to be 0 indexed


getLineNumber getColumnNumber

q: in case we have a invalid line number either <0 or > max actual line# what will happen? as long as it doesn't crash.

corrected.

Manually tested by intentionally feeding it with line number -1, there is no crash, just the cursor is somewhere random.

Non numbers will be caught by NumberFormatException, and return no link.

wisechengyi · 2017-01-13T22:25:03Z

Thanks @peiyuwang !

* Add usage logging extension point (#239) * GUI import fix (#244) * Move Pants output to console view instead of notification channel (#242)

wisechengyi added 3 commits January 9, 2017 17:44

can show up at awkward place

9d60d48

shows up in console now

4d66e94

move to UI

ac96cb4

wisechengyi changed the title ~~Move Pants output goes to console instead of notification channel~~ Move Pants output to console view instead of notification channel Jan 10, 2017

wisechengyi added 16 commits January 9, 2017 23:50

yes colors

b152ade

Merge branch 'master' into console

8f649ff

Revert "yes colors"

95adbb7

This reverts commit b152ade.

basic hyperlink

3209a76

basically good

9fe1d2c

looks ok

ef0833e

try it out

0dd30ee

invokelater

ff240f8

register disposable

16bf322

clean up and doc

c7d772d

testonly dispose all

4cf55fc

fix

ed6c139

rename stale name

0c4455f

use optional

9532921

more doc

39d2649

ws

1cb5b88

wisechengyi requested review from baroquebobcat, benjyw, areitz and peiyuwang and removed request for areitz January 11, 2017 19:21

wisechengyi added the reviewable label Jan 11, 2017

wisechengyi requested a review from stuhood January 11, 2017 19:27

wisechengyi added 3 commits January 11, 2017 17:53

2.11.8

ce904a4

put it back

91d0bbf

Merge branch 'master' into console

c3d1080

peiyuwang reviewed Jan 13, 2017

View reviewed changes

wisechengyi added 4 commits January 13, 2017 13:17

test is good

9ba2a0c

refactor

3f0000b

Merge branch 'master' into console

9e3bc58

update doc

568ef7b

peiyuwang approved these changes Jan 13, 2017

View reviewed changes

getter

6e17423

wisechengyi merged commit 9cce5de into pantsbuild:master Jan 13, 2017

wisechengyi mentioned this pull request Jan 14, 2017

Release 1.5.2 #248

Merged

wisechengyi added a commit that referenced this pull request Jan 15, 2017

Release 1.5.2 (#248)

4383994

* Add usage logging extension point (#239) * GUI import fix (#244) * Move Pants output to console view instead of notification channel (#242)

wisechengyi deleted the console branch July 31, 2017 22:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move Pants output to console view instead of notification channel #242

Move Pants output to console view instead of notification channel #242

wisechengyi commented Jan 10, 2017 •

edited

Loading

peiyuwang Jan 13, 2017

wisechengyi Jan 13, 2017

peiyuwang Jan 13, 2017

wisechengyi Jan 13, 2017

wisechengyi Jan 13, 2017

peiyuwang Jan 13, 2017

peiyuwang Jan 13, 2017

wisechengyi Jan 13, 2017

wisechengyi Jan 13, 2017 •

edited

Loading

peiyuwang Jan 13, 2017

wisechengyi commented Jan 13, 2017

Move Pants output to console view instead of notification channel #242

Move Pants output to console view instead of notification channel #242

Conversation

wisechengyi commented Jan 10, 2017 • edited Loading

Problem

Solution

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wisechengyi Jan 13, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wisechengyi commented Jan 13, 2017

wisechengyi commented Jan 10, 2017 •

edited

Loading

wisechengyi Jan 13, 2017 •

edited

Loading