[CMSP-459] Updates behat tests and behaviors. #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are some of these tests specific to #426 and therefore now failing on this branch? |
|
it's possible the base branch of this PR should be |
|
There were both test regressions (tests needed to be fixed) and legitimate errors (code needed to be fixed) @rwagner00 addressed in getting #426 green. Anything that fixes |
we end up making a dozen differnet enable redis requests and inevitably a lot of those fail because there are so many happening simultaneously (assumption). It's okay to just enable it and leave it on, rather than turning it on and off.
jazzsequence
changed the title
jazzsequence
added a commit
that referenced
this pull request
Jun 26, 2023
* Updates behat tests and behaviors. * Updates behat tests and behaviors. * port diff from #426 * tabs to spaces * don't enable redis as part of the prepare step we end up making a dozen differnet enable redis requests and inevitably a lot of those fail because there are so many happening simultaneously (assumption). It's okay to just enable it and leave it on, rather than turning it on and off. --------- Co-authored-by: Ryan Wagner <[email protected]> Co-authored-by: Chris Reynolds <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports behat fixes from https://github.com/pantheon-systems/wp-redis/pull/429/files into its own PR.
This PR also removes the
terminus redis:enablestep inbin/behat-prepare.sh. There's no reason to ever disable redis on the fixture running Behat tests, and the enable step spawns many duplicate "redis enable" requests, most of which time-out, causing the tests to fail.Tests can be seen as passing (with #437) here: https://app.circleci.com/pipelines/github/pantheon-systems/wp-redis/1629/workflows/fd714abf-075f-45f8-9102-3ddc730f731e/jobs/4980