Connect via unix socket instead of filesystem to be compatible with php open_basedir restrictions. #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hp open_basedir restrictions. copied from #425
pwtyler
force-pushed
the
update-object-cache
branch
from
9bdc441 to
8e103ca
Compare
pwtyler
previously approved these changes
Jun 5, 2023
pwtyler
dismissed
their stale review
Looks like behat failures may be legitimate, need to investigate.
added 12 commits
June 7, 2023 14:20
jazzsequence
commented
Jun 8, 2023
added 10 commits
June 9, 2023 14:33
jazzsequence
added a commit
that referenced
this pull request
Jun 22, 2023
jazzsequence
added a commit
that referenced
this pull request
Jun 23, 2023
* Updates behat tests and behaviors. * Updates behat tests and behaviors. * port diff from #426 * tabs to spaces * don't enable redis as part of the prepare step we end up making a dozen differnet enable redis requests and inevitably a lot of those fail because there are so many happening simultaneously (assumption). It's okay to just enable it and leave it on, rather than turning it on and off. --------- Co-authored-by: Ryan Wagner <[email protected]> Co-authored-by: Chris Reynolds <[email protected]>
jazzsequence
added a commit
that referenced
this pull request
Jun 26, 2023
* Updates behat tests and behaviors. * Updates behat tests and behaviors. * port diff from #426 * tabs to spaces * don't enable redis as part of the prepare step we end up making a dozen differnet enable redis requests and inevitably a lot of those fail because there are so many happening simultaneously (assumption). It's okay to just enable it and leave it on, rather than turning it on and off. --------- Co-authored-by: Ryan Wagner <[email protected]> Co-authored-by: Chris Reynolds <[email protected]>
|
This PR ended up all over the place and ultimately derailed on the testing. Going to close and re-open the original PR (although we still need to prioritize the work on the teamside). As we've learned since this was attempted, pushing fork PRs to a separate branch (rather than opening a new PR) stills gives us the circle checks in the original PR. Better/cleaner would be to move all tests to Github actions triggered "On PR", which can be approved by a codeowner to run CI after manually reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copied from #425 to run CI workflows by @hj-collab
Behat fixes ported to #429