-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move branch workflow from develop and master to default and release #417
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,7 +16,7 @@ workflows: | |
filters: | ||
branches: | ||
only: | ||
- master | ||
- release | ||
jobs: | ||
- test-behat | ||
jobs: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ updates: | |
interval: weekly | ||
timezone: America/Los_Angeles | ||
day: tuesday | ||
target-branch: "develop" | ||
target-branch: "default" | ||
open-pull-requests-limit: 99 | ||
ignore: | ||
- dependency-name: phpunit/phpunit | ||
|
@@ -16,12 +16,4 @@ updates: | |
- dependency-name: phpunit/phpunit | ||
versions: | ||
- ">= 9.a" | ||
- "< 10" | ||
- package-ecosystem: npm | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Confirming: no reason for NPM on this project, right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not that I'm aware of. It might be possible to dig through the history to see what it was used for, but I don't think it's used for anything currently. |
||
directory: "/" | ||
schedule: | ||
interval: weekly | ||
timezone: America/Los_Angeles | ||
day: tuesday | ||
target-branch: "develop" | ||
open-pull-requests-limit: 99 | ||
- "< 10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sold that "default" is better than
develop
as a branch name. Agree aboutmaster
->release
. But I suppose it might make the GitHub "default" branch appear more "stable" if it's calleddefault
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's my thought, I want it abundantly clear that this is the branch to merge in and out of, for all the people not reading CONTRIBUTING.md 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also add a PR template 😁