Move branch workflow from develop and master to default and release #417
Conversation
| @@ -16,12 +16,4 @@ updates: | |||
| - dependency-name: phpunit/phpunit | |||
| versions: | |||
| - ">= 9.a" | |||
| - "< 10" | |||
| - package-ecosystem: npm | |||
There was a problem hiding this comment.
Confirming: no reason for NPM on this project, right?
There was a problem hiding this comment.
Not that I'm aware of. It might be possible to dig through the history to see what it was used for, but I don't think it's used for anything currently.
| @@ -6,7 +6,7 @@ updates: | |||
| interval: weekly | |||
| timezone: America/Los_Angeles | |||
| day: tuesday | |||
| target-branch: "develop" | |||
| target-branch: "default" | |||
There was a problem hiding this comment.
I'm not sold that "default" is better than develop as a branch name. Agree about master -> release. But I suppose it might make the GitHub "default" branch appear more "stable" if it's called default.
There was a problem hiding this comment.
That's my thought, I want it abundantly clear that this is the branch to merge in and out of, for all the people not reading CONTRIBUTING.md 😁
There was a problem hiding this comment.
We should also add a PR template 😁
| @@ -16,12 +16,4 @@ updates: | |||
| - dependency-name: phpunit/phpunit | |||
| versions: | |||
| - ">= 9.a" | |||
| - "< 10" | |||
| - package-ecosystem: npm | |||
There was a problem hiding this comment.
Not that I'm aware of. It might be possible to dig through the history to see what it was used for, but I don't think it's used for anything currently.
Before creating this PR, I branched
defaultfromdevelopandreleasefrommaster.After merging this PR, I will change the repo's default branch from
mastertodefault, and adjust branch protection rules fordefaultandrelease.I intend these to be the branch names we use for our common WordPress plugin release workflow as we build out the automation steps.