Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.4.0 #409

Merged
merged 6 commits into from
May 9, 2023
Merged

Release 1.4.0 #409

merged 6 commits into from
May 9, 2023

Conversation

jspellman814
Copy link

No description provided.

@jspellman814 jspellman814 requested review from a team as code owners May 8, 2023 20:44
@pwtyler
Copy link
Member

pwtyler commented May 8, 2023

EDIT: develop, not default

Most of these changes are already in master, but were squashed in #397. Because of that, this PR will not be able to be rebased and merged. I'm not confident in any one strategy here because they all seem fairly unpalatable—

  • we could rebase develop onto main and deal with all the merge conflicts, then re-open this PR. I think this will still be messy.
  • we could stash any commits that post-date 3734c41, delete develop, check out a fresh copy then cherry-pick them back to develop, then re-open this PR
  • we could merge this PR (but not rebase) then delete develop and re-create it based off master after 1.4.0 is released.

I'm in favor of the second one ^ but not firmly attached.

@jspellman814
Copy link
Author

@pwtyler By default do you mean develop?

@pwtyler
Copy link
Member

pwtyler commented May 8, 2023

@pwtyler By default do you mean develop?

🤦🏻 yes. Will edit my message ^

dependabot bot and others added 6 commits May 8, 2023 17:32
Bumps [behat/behat](https://github.com/Behat/Behat) from 3.12.0 to 3.13.0.
- [Release notes](https://github.com/Behat/Behat/releases)
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md)
- [Commits](Behat/Behat@v3.12.0...v3.13.0)

---
updated-dependencies:
- dependency-name: behat/behat
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…elop/behat/behat-3.13.0

Bump behat/behat from 3.12.0 to 3.13.0
* add our coding standards

* use php 8 for linting

* phpcbf fixes

* ignore tests for linting

* adjust and fix sniffs for object-cache.php drop-in

* check if all the server global values

* fix sniffs for WP CLI commands

* do a composer update before install for 7.4

* make the $cache property public

* fix composer update & install in both 7.4 tests

* set $cache_hits property to true

* set redis_calls property to public

* set is_redis_connected property to public

* revert wp_redis_ignore_global_groups const value

* make all the private and protected properties public

* use short arrays again

* remove parenthesis when we instantiate the class

* set object-cache back to what it was

* remove extra isset checks

* add the issets back to the database param

* add original object-cache file back

* use the version of the upstream tests that maybe have the issues fixed

* update the upstream tests

* Revert "add original object-cache file back"

This reverts commit 1fc2b66.

* restore cli.php and wp-redis.php back to what they were

* remove the upstream behat tests
these are failing because they're old and need to be updated. they have nothing to do with the plugin itself

* add some echos

* wordpress isn't actually getting installed
break the brackets

* one line, brackets and remove the &

* guess we can't do this on one line

* don't need that semicolon
i don't think

* okay fine, put it back the way it was

* enable redis before flushing cache

* enable redis on the entire site (not env) and add a wait command

* enable redis early
so we aren't potentially waiting for other things later

* don't need to wait

* don't need to enable because it's already enabled

* don't need an isset, we already know it's set

* use strip all tags instead of sanitize_text_field

* don't activate redis twice and flush cache after wp-redis is active

* re-add composer.lock

* re-add composer update for 7.4
@jspellman814 jspellman814 merged commit 5c97876 into master May 9, 2023
@jspellman814 jspellman814 deleted the release_1.4.0 branch May 9, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants