Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to CONTRIBUTING.md #406

Merged
merged 10 commits into from
May 2, 2023
Merged

Updates to CONTRIBUTING.md #406

merged 10 commits into from
May 2, 2023

Conversation

jspellman814
Copy link

No description provided.

@jspellman814 jspellman814 requested review from a team as code owners May 1, 2023 21:05
pwtyler
pwtyler reviewed May 1, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
pwtyler
pwtyler previously approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@pwtyler pwtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got confused by how master and develop had diverged and thought there were a lot more changes outstanding. Will need to address that separately once we get to cutting a release.

@jspellman814 jspellman814 requested a review from pwtyler May 2, 2023 15:32
pwtyler
pwtyler previously approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@pwtyler pwtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer to see distinct circle steps here otherwise lgtm

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@pwtyler
Update .circleci/config.yml
9ebb760 
Co-authored-by: Phil Tyler <[email protected]>
@pwtyler
Update .circleci/config.yml
f887ac9 
Co-authored-by: Phil Tyler <[email protected]>
@jspellman814 jspellman814 requested a review from pwtyler May 2, 2023 17:37
@pwtyler pwtyler mentioned this pull request May 2, 2023
Merged
@jspellman814 jspellman814 merged commit 943490c into develop May 2, 2023
@jspellman814 jspellman814 deleted the contrib-md branch May 2, 2023 17:58
@jazzsequence jazzsequence mentioned this pull request May 4, 2023
Open
jspellman814 pushed a commit that referenced this pull request May 8, 2023
Updates to CONTRIBUTING.md (#406)
8361a0a
jspellman814 pushed a commit that referenced this pull request May 9, 2023
Updates to CONTRIBUTING.md (#406)
2c4048f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwtyler pwtyler pwtyler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jspellman814 @pwtyler