Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes Merged from #360 Break Redis Connections on Pantheon Due to #400 and Incorrect array_replace_recursive call #433

Closed
timnolte opened this issue Jun 21, 2023 · 0 comments · Fixed by #434

Comments

@timnolte
Copy link
Contributor

After further testing there with Pantheon after the merge of changes in #360 to resolve those caused by #400 it was discovered that there was an error in the usage of array_replace_recursive(). (Noted: #360 (comment)) I updated a Gist with a patch that fixes this, however, this should be applied here before the next release otherwise it will break all Object Caching on Pantheon sites that deploy the plugin.

timnolte added a commit to timnolte/wp-redis that referenced this issue Jun 21, 2023

Verified

This commit was signed with the committer’s verified signature.
timnolte Tim Nolte
…er issues

* Fixes pantheon-systems#433
* Fixes $432
* Fixes pantheon-systems#431
* Further clean-up & standardization between object-cache.php & wp-redis.php.
* Fixes incorrect order of array_replace_recursive arguments.
* Addresses issue with port still not being null for socket connections due to defaults array_repalce_recursive use.
timnolte added a commit to timnolte/wp-redis that referenced this issue Jun 21, 2023

Verified

This commit was signed with the committer’s verified signature.
timnolte Tim Nolte
…er issues

* Fixes pantheon-systems#433
* Fixes pantheon-systems#432
* Fixes pantheon-systems#431
* Further clean-up & standardization between object-cache.php & wp-redis.php.
* Fixes incorrect order of array_replace_recursive arguments.
* Addresses issue with port still not being null for socket connections due to defaults array_repalce_recursive use.
jazzsequence pushed a commit to timnolte/wp-redis that referenced this issue Jun 23, 2023

Verified

This commit was signed with the committer’s verified signature.
jazzsequence Chris Reynolds
…er issues

* Fixes pantheon-systems#433
* Fixes pantheon-systems#432
* Fixes pantheon-systems#431
* Further clean-up & standardization between object-cache.php & wp-redis.php.
* Fixes incorrect order of array_replace_recursive arguments.
* Addresses issue with port still not being null for socket connections due to defaults array_repalce_recursive use.
jazzsequence added a commit that referenced this issue Jun 23, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…er issues (#434)

* fix: Fixes incorrect order of array_replace_recursive arguments & other issues

* Fixes #433
* Fixes #432
* Fixes #431
* Further clean-up & standardization between object-cache.php & wp-redis.php.
* Fixes incorrect order of array_replace_recursive arguments.
* Addresses issue with port still not being null for socket connections due to defaults array_repalce_recursive use.

* fix: Fixes sanitization methods and linting issues

* Adjusts some items to use type-based sanitization.
* Adds linting expection handling with comments for cases that require it.

* fix: Removes invalid change made in #437

* Reverts this incorrect change that was made due to the incorrect use of `array_replace_recursive()`.

* update  changelog

* Update wp-redis.php

* update language in changelogs

* fix missing closing )

---------

Co-authored-by: Chris Reynolds <[email protected]>
Co-authored-by: Phil Tyler <[email protected]>
jazzsequence added a commit that referenced this issue Jun 26, 2023
…er issues (#434)

* fix: Fixes incorrect order of array_replace_recursive arguments & other issues

* Fixes #433
* Fixes #432
* Fixes #431
* Further clean-up & standardization between object-cache.php & wp-redis.php.
* Fixes incorrect order of array_replace_recursive arguments.
* Addresses issue with port still not being null for socket connections due to defaults array_repalce_recursive use.

* fix: Fixes sanitization methods and linting issues

* Adjusts some items to use type-based sanitization.
* Adds linting expection handling with comments for cases that require it.

* fix: Removes invalid change made in #437

* Reverts this incorrect change that was made due to the incorrect use of `array_replace_recursive()`.

* update  changelog

* Update wp-redis.php

* update language in changelogs

* fix missing closing )

---------

Co-authored-by: Chris Reynolds <[email protected]>
Co-authored-by: Phil Tyler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant