[CMSP-467] Please don't strip all tags from the cache password. #431
Comments
|
Thanks for the report! Tracking internally as CMSP-467. Looks like another unintended side-effect of #400. |
pwtyler
changed the title
timnolte
added a commit
to timnolte/wp-redis
that referenced
this issue
Jun 21, 2023
…er issues * Fixes pantheon-systems#433 * Fixes $432 * Fixes pantheon-systems#431 * Further clean-up & standardization between object-cache.php & wp-redis.php. * Fixes incorrect order of array_replace_recursive arguments. * Addresses issue with port still not being null for socket connections due to defaults array_repalce_recursive use.
timnolte
added a commit
to timnolte/wp-redis
that referenced
this issue
Jun 21, 2023
…er issues * Fixes pantheon-systems#433 * Fixes pantheon-systems#432 * Fixes pantheon-systems#431 * Further clean-up & standardization between object-cache.php & wp-redis.php. * Fixes incorrect order of array_replace_recursive arguments. * Addresses issue with port still not being null for socket connections due to defaults array_repalce_recursive use.
Closed
jazzsequence
pushed a commit
to timnolte/wp-redis
that referenced
this issue
Jun 23, 2023
…er issues * Fixes pantheon-systems#433 * Fixes pantheon-systems#432 * Fixes pantheon-systems#431 * Further clean-up & standardization between object-cache.php & wp-redis.php. * Fixes incorrect order of array_replace_recursive arguments. * Addresses issue with port still not being null for socket connections due to defaults array_repalce_recursive use.
jazzsequence
added a commit
that referenced
this issue
Jun 26, 2023
…er issues (#434) * fix: Fixes incorrect order of array_replace_recursive arguments & other issues * Fixes #433 * Fixes #432 * Fixes #431 * Further clean-up & standardization between object-cache.php & wp-redis.php. * Fixes incorrect order of array_replace_recursive arguments. * Addresses issue with port still not being null for socket connections due to defaults array_repalce_recursive use. * fix: Fixes sanitization methods and linting issues * Adjusts some items to use type-based sanitization. * Adds linting expection handling with comments for cases that require it. * fix: Removes invalid change made in #437 * Reverts this incorrect change that was made due to the incorrect use of `array_replace_recursive()`. * update changelog * Update wp-redis.php * update language in changelogs * fix missing closing ) --------- Co-authored-by: Chris Reynolds <[email protected]> Co-authored-by: Phil Tyler <[email protected]>
|
Thanks and greetings from Bavaria |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thanks for developing such a great plugin and maintaining it.
I noticed a bug: commenting it out helped:
ERRORS:
[1] This corrupts our passwords and authentication fails.
[2] If the CACHE_PASSWORD is provided as a user+pw pair, WP errors that it needs a string.
Thanks for looking into this.
Dennis
The text was updated successfully, but these errors were encountered: