Release 0.4.4 #150
Merged
Release 0.4.4 #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jazzsequence
commented
Dec 6, 2024
jazzsequence
commented
- Fix admin bar item layout issue [#145] props @cbirdsong and @westonruter
- Update CONTRIBUTING.md [#123]
- Added "environment-indicator" to tags [#128]
- Updates Pantheon WP Coding Standards to 2.0 [#131]
we include this in our standard
mostly just phpcbf stuff
…standards Add pantheon-wp-coding-standards
* Update contributing.md * correct pr number
* add a lint & test gh action copying from solr-power for prior art * add branches to on push hook * fix mariadb image names * set to all branches * only one * ? * need quotes * don't use pantheon build image * run an update before install for 7.4 * fix missing database host * use root pw * remove duplicative circle jobs * remove behat test migration there's some ssh stuff going on that I need to figure out, punting for now * use hashfiles checksum doesn't do anything * give the lint step a name * add wp.org validation * suggestions from CR * simplify the phpunit step by using a script * exit for errors * set current directory to a variable * explicitly bash the file? * change the bash environment used * put quotes around the entire string * wrap just the sh path in quotes and use a single = * use realpath * update dirname * remove all that as well as the =
* Validate README header spacing * Fix spacing called out by new linter
Bumps [yoast/phpunit-polyfills](https://github.com/Yoast/PHPUnit-Polyfills) from 1.0.5 to 2.0.0. - [Release notes](https://github.com/Yoast/PHPUnit-Polyfills/releases) - [Changelog](https://github.com/Yoast/PHPUnit-Polyfills/blob/2.x/CHANGELOG.md) - [Commits](Yoast/PHPUnit-Polyfills@1.0.5...2.0.0) --- updated-dependencies: - dependency-name: yoast/phpunit-polyfills dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* replace wpcs reference with link to Pantheon WP Coding Standards * linting fixes * ignore unsanitized input warnings on api and toolbar those inputs are coming from Pantheon $_ENV variables and can be considered safe. * newline * bump pantheon coding standards to 2.0 drop patch specificity * update changelog
* update ci to run on main, not master * update contributing to reference main instead of master * use `main` everywhere else * bump phpunit polyfills * activate twentytwentythree for behat tests * move the twentytwentythree theme activation don't need to activate two themes in the workflow * apply upstream updates automatically * apply the upstream updates to dev the ci environment hasn't been created yet and we want it to be on the master branch * set git mode earlier so we can apply upstream updates * not site_env * update other references to `master` * switch to main and release * better error handling for testing fixture version * bump tested up to version * fix version_compare logic the -1 return from version_compare converts to 255 which was causing that to fail. this captures the output as a string that we can explicitly compare against. * restore the "environment-indicator" tag * remove john from plugin contributors sorry john 😞 * revert previous language for release commits Co-authored-by: Phil Tyler <[email protected]> * add note about merge commit Co-authored-by: Phil Tyler <[email protected]> * add xyz-dev heading Co-authored-by: Phil Tyler <[email protected]> * update message to include fixture version Co-authored-by: Phil Tyler <[email protected]> * check for updates before apply * change "Latest" to "X.Y.Z-dev" to align with current best practice * re-add lint badge * remove exit 0 Co-authored-by: Phil Tyler <[email protected]> --------- Co-authored-by: Phil Tyler <[email protected]>
* set circle badge to main rather than master this existed in an earlier incarnation but likely got swallowed by reverts/merge conflicts when the base branch was changed * fix readme.md spacing
* add some local test helpers * let's see where the tests dir lives on ci * try another thing maybe? * add a new local phpunit install script and use that * use the right option * nocache isn't an option for composer... * remove the wp dir paths we don't need them if we're setting TMPDIR * update the message about where we're installing tests * use newer versions of phpcompatibility for php8 checks * add php8 check and add to lint script * run the php8-check lint in php8.2 tests the tests run composer phpcs but not composer lint. lint combines phpcs and php8-check so we'll run the php8-check manually * add new tests for 8.3 * use dev-develop rather than dev-master * trash all that and use the GH action * restore line break that i inadvertently removed * just remove the 8.2 tests we don't really need to test both things * update comment * run a phplint composer lint is not run, only phpcs, and that's run in a non-php-specific environment, so splitting it out into a separate script and composer lint runs both * run the phplint script in both the 7.4 and 8.3 tests * allow any install-wp-tests parameter to be passed in
contributors don't have commit access, only listed committers in the plugin's Advanced view, see https://developer.wordpress.org/plugins/wordpress-org/special-user-roles-capabilities/#committer
* bump tested up to version * some variable cleanup * echo the php version so we know we're on the right one * ignore the newrelic error * fix readme.md spacing * use the right terminus command * return FIXTURE_VERSION to what it was originally this will be broken until pantheon-systems/infrastructure#3574 is merged, but then we can re-run and it should work * remove comment
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
[[SITE-1547] Add catalog-info.yml
…40923 Rename catalog-info.yml to catalog-info.yaml
* Add inline block to pantheon logo img On a theme where images are set to `display: block`, the Pantheon logo pushes the environment label out of the admin bar item. This fixes it. * Update inc/class-toolbar.php Co-authored-by: Weston Ruter <[email protected]> --------- Co-authored-by: Phil Tyler <[email protected]> Co-authored-by: Weston Ruter <[email protected]>
* add jazzsequence/action-validate-plugin-version * bump tested-up-to version * bump behat upstream tests * fix line endings
pwtyler
previously approved these changes
Dec 6, 2024
(back, maybe?)
pwtyler
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.