Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SITE-2846] Fix admin bar item layout issue #145

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

cbirdsong
Copy link
Contributor

The Pantheon logo pushes the environment label out of the admin bar item if the theme has this fairly common bit of CSS:

img {
  display: block;
}

CleanShot 2024-11-12 at 17 10 50

Adding display: inline-block; to the icon fixes it:

CleanShot 2024-11-12 at 17 13 29

On a theme where images are set to `display: block`, the Pantheon logo pushes the environment label out of the admin bar item. This fixes it.
@cbirdsong cbirdsong requested a review from a team as a code owner November 12, 2024 23:18
@jazzsequence jazzsequence requested a review from pwtyler November 13, 2024 17:53
@jazzsequence
Copy link
Contributor

Thanks for the PR @cbirdsong
Tagging @pwtyler for 2nd approval.

@westonruter
Copy link
Contributor

I just opened a PR (#146) to fix the same issue, and then I saw this PR!

inc/class-toolbar.php Outdated Show resolved Hide resolved
@jazzsequence
Copy link
Contributor

we've updated our GH policies to require 2 approvals on all PRs which is pretty much the main reason this hasn't been merged yet. When we can get another ✅ this will get merged and released. Hang tight, y'all.

Co-authored-by: Weston Ruter <[email protected]>
@scottbuscemi scottbuscemi changed the title Fix admin bar item layout issue [SITE-2846] Fix admin bar item layout issue Nov 22, 2024
@jazzsequence jazzsequence reopened this Nov 25, 2024
@jazzsequence jazzsequence mentioned this pull request Nov 25, 2024
@jazzsequence jazzsequence merged commit 912606a into pantheon-systems:main Nov 25, 2024
6 of 7 checks passed
@jazzsequence jazzsequence mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants