Logging & Import Updates #123

wtgee · 2020-03-02T21:58:45Z

Logger updates
- The panoptes-utils modules use loguru for logging with it disabled by default. There are no settings changed from the default.
- The get_root_logger has been entirely revamped and simplified to use loguru but with settings appropriate for use in POCS.
Consistent use of relative imports.
Misc. cleanup.

Part of #90
Closes #89

Consistent use of relative module imports. Other minor cleanup.

* Only add filenames for active file based handlers. * Only `all` logger is active by default.

codecov-io · 2020-03-02T22:02:42Z

Codecov Report

Merging #123 into develop will decrease coverage by 0.7%.
The diff coverage is 83.33%.

@@             Coverage Diff             @@
##           develop     #123      +/-   ##
===========================================
- Coverage     69.9%   69.19%   -0.71%     
===========================================
  Files           26       26              
  Lines         1904     1753     -151     
  Branches       274      234      -40     
===========================================
- Hits          1331     1213     -118     
+ Misses         509      482      -27     
+ Partials        64       58       -6

Impacted Files	Coverage Δ
panoptes/utils/library.py	`95% <100%> (ø)`	⬆️
panoptes/utils/social/twitter.py	`100% <100%> (+18.18%)`	⬆️
panoptes/utils/logger.py	`100% <100%> (+2.43%)`	⬆️
panoptes/utils/database/__init__.py	`90% <100%> (+0.52%)`	⬆️
panoptes/utils/theskyx.py	`91.66% <100%> (ø)`	⬆️
panoptes/utils/images/polar_alignment.py	`97.77% <100%> (ø)`	⬆️
panoptes/utils/database/file.py	`95.89% <100%> (-0.32%)`	⬇️
panoptes/utils/utils.py	`92.04% <100%> (-0.18%)`	⬇️
panoptes/utils/rs232.py	`86.36% <100%> (-0.25%)`	⬇️
panoptes/utils/messaging.py	`57.28% <100%> (ø)`	⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a0633a...13f67d2. Read the comment docs.

* Small cleanup. * Restore some `warn` instead of log.

* README updates * Adding TOC to README

* Restoring tests with caplog. * `make_pretty_image` works for `fz` files.

* Fixing make_pretty_image for fz files

* Switching library to `loguru` for easier logs. * Disabled in `panoptes-utils` by default. * Logs in JSON to daily rotated file. Later can upload that file.

* More complete conda file. * Docker builds pip and pyyaml, then conda file, then requirements.txt. * Adding loguru dependency

* root logger can take file name or dir. * Better docstring. * Removed old logger tests.

* Better logger tests. * Suppress error removing handler from caplog for testing. Not sure why it appears.

wtgee added 7 commits March 2, 2020 09:04

Consistent import of base logging module.

c9337da

Consistent use of relative module imports. Other minor cleanup.

* Adding JSON output logging and making it default.

c17cbae

* Only add filenames for active file based handlers. * Only `all` logger is active by default.

Remove all root logger from testing

1959f56

Improve testing scripts

a5039ab

Remove unused code in setup

f48c50f

Remove more unused code in setup

a600035

More cleanup to setup

db7b3f2

wtgee added 3 commits March 2, 2020 12:10

* Remove unused log config.

d01349d

* Small cleanup. * Restore some `warn` instead of log.

Small test to get coverage on get_root_logger

b0fbbaa

Adding tests for coverage

6f7d9aa

wtgee mentioned this pull request Mar 2, 2020

Logging System overhaul #90

Closed

8 tasks

wtgee added this to the v0.2.0 - The Cleanup milestone Mar 2, 2020

wtgee added the logging label Mar 2, 2020

wtgee added 16 commits March 2, 2020 13:05

* Raise exception when can't insert into db instead of just warn.

8bf6940

Make memory db match

a545669

Slight test coverage

8ee31f1

Fix typo

dbf3def

Simplify test

dd06998

* Default back to normal logging (not JSON)

0fb08a7

* README updates * Adding TOC to README

* Restoring test for invalid db collection.

60ffc2a

* Restoring tests with caplog. * `make_pretty_image` works for `fz` files.

Raise exception for bad timelapse

6650d88

* Moving mask_saturated into image utils.

0a7f502

* Fixing make_pretty_image for fz files

Fix test for make pretty

a9fbf5f

Logging updates

13a5b07

* Switching library to `loguru` for easier logs. * Disabled in `panoptes-utils` by default. * Logs in JSON to daily rotated file. Later can upload that file.

Updating requirements

86ba6b6

* More complete conda file. * Docker builds pip and pyyaml, then conda file, then requirements.txt. * Adding loguru dependency

Logger

71cd338

* root logger can take file name or dir. * Better docstring. * Removed old logger tests.

* Enable the given profile.

ec34080

Fix FITS test

738b06a

* Logger by default does not print to stderr.

36431f2

* Better logger tests. * Suppress error removing handler from caplog for testing. Not sure why it appears.

wtgee added 20 commits March 3, 2020 10:35

Better logger coverage

60e56ab

Typo

8c48f92

Coverage cheat

cd4db06

Updating readme with logger instructions.

5ef3f18

Remove unused library

489f4d2

Adding module logging example

9efd1ec

Adding simple convenience function to return the logger instance.

3ba8226

Updating logging details

5603728

More consistent and better use of import

c6fdb4a

Adding namespae file

53d26c7

Small change to README

a5e2246

Updating docker readme

284a08f

Move docker file to folder as readme

1432989

Updates to docker readme

d164d7b

Small README updates

9d22d11

Update README headers

5d33cd3

Moving some tests into subfolder

590648c

Reverting addition to plate solve that adds png

6b4d513

Adding params to get_root_logger

13f67d2

Remove unused code.

ecc5059

wtgee merged commit 4631a2b into panoptes:develop Mar 4, 2020

wtgee deleted the logging-updates-90 branch March 4, 2020 21:05

wtgee mentioned this pull request Mar 4, 2020

Log File Upload panoptes/POCS#961

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Logging & Import Updates #123

Logging & Import Updates #123

wtgee commented Mar 2, 2020 •

edited

Loading

codecov-io commented Mar 2, 2020 •

edited

Loading

Logging & Import Updates #123

Logging & Import Updates #123

Conversation

wtgee commented Mar 2, 2020 • edited Loading

codecov-io commented Mar 2, 2020 • edited Loading

Codecov Report

wtgee commented Mar 2, 2020 •

edited

Loading

codecov-io commented Mar 2, 2020 •

edited

Loading