Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken travis tests #714

Merged
merged 4 commits into from
Oct 30, 2018
Merged

Fix broken travis tests #714

merged 4 commits into from
Oct 30, 2018

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented Oct 30, 2018

There is ongoing work in #711, #712 and #713 to update some of the travis install for astrometry-net, but in light of the fact that astrometry.net website will be down for an unknown amount of time, this PR simply switches the URL to the github release page, which will unblock #709 and #710.

Edit: Also fixes numpy version to fix IERS import.

@wtgee wtgee added bug Quick PR This PR should be quick to review. labels Oct 30, 2018
@wtgee wtgee changed the title Change the astrometry-net url to github relaeses Change the astrometry-net url to github releases Oct 30, 2018
@wtgee wtgee changed the title Change the astrometry-net url to github releases Fix broken travis tests Oct 30, 2018
@wtgee wtgee requested a review from jamessynge October 30, 2018 21:08
Copy link
Contributor

@jamessynge jamessynge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for extracting the critical bits from my exploratory PRs.

@codecov
Copy link

codecov bot commented Oct 30, 2018

Codecov Report

Merging #714 into develop will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #714      +/-   ##
===========================================
- Coverage    80.09%   80.03%   -0.06%     
===========================================
  Files           61       61              
  Lines         5078     5078              
  Branches       693      693              
===========================================
- Hits          4067     4064       -3     
- Misses         817      820       +3     
  Partials       194      194
Impacted Files Coverage Δ
pocs/dome/astrohaven.py 71.05% <0%> (-2.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ce3e19...9d61fb6. Read the comment docs.

@wtgee wtgee merged commit c897587 into panoptes:develop Oct 30, 2018
@wtgee wtgee deleted the astrometry-net-url branch October 30, 2018 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Quick PR This PR should be quick to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants