Test caching of astrometry and using libcfitsio packages #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing cfitsio-bin and cfitsio* as packages instead of libcfitsio(-dev|-bin|5). Travis not updated to more recent Ubuntu release, probably a good reason to use a container approach for building as that will probably provide us more choices of base images.
wtgee
approved these changes
Oct 24, 2018
.travis.yml
Outdated
| @@ -49,13 +50,21 @@ addons: | |||
| - libbz2-dev | |||
| - swig | |||
| - cfitsio-dev | |||
| - cfitsio | |||
| - cfitsio* | |||
There was a problem hiding this comment.
Can the cfitsio* just be one line? And looks like this is failing.
There was a problem hiding this comment.
No, doesn't work at all. I'll have to stick with the current install method for the moment.
.travis.yml
Outdated
| @@ -8,8 +8,9 @@ python: | |||
| env: | |||
| - PANDIR=$HOME POCS=$TRAVIS_BUILD_DIR PANUSER=$USER ARDUINO_VERSION=1.8.1 | |||
| before_install: | |||
| - pwd | |||
.travis.yml
Outdated
| cd astrometry.net-0.72 && \ | ||
| make && \ | ||
| make py && \ | ||
| make install INSTALL_DIR=$PANDIR/astrometry && \ |
There was a problem hiding this comment.
Ack. Will probably make more submits (errors) before I'm ready to request a review.
Not sure if this error was related to the IERS A bulletin or due to astrometry.net being offline: ``` $ python pocs/utils/data.py --folder $PANDIR/astrometry/data Downloading http://maia.usno.navy.mil/ser7/finals2000A.all |==========================================| 3.2M/3.2M (100.00%) 0s Failed to download IERS A bulletin: invalid literal for int() with base 10: 'N' ```
Testing a pytest hook addition to workaround the error with the contents of the IERS Bulletin A. The hook calls an astroplan method that installs a workaround IFF the bulletin couldn't be downloaded.
Codecov Report
@@ Coverage Diff @@
## develop #712 +/- ##
===========================================
- Coverage 80.09% 80.03% -0.06%
===========================================
Files 61 61
Lines 5078 5078
Branches 693 693
===========================================
- Hits 4067 4064 -3
- Misses 817 820 +3
Partials 194 194
Continue to review full report at Codecov.
|
Remove uses of sudo, remove "sudo: required", which apparently can unlock better performance. Incrementally add to PATH as packages are installed.
Previous attempt with "arduino --version" to show the version number failed. Current version (1.8.7) documentation claims that command works. Let's see.
This was referenced Oct 27, 2018
This was referenced Oct 30, 2018
Merged
|
Closing in favor of other changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.