Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the cameras to the POCS tests #646

Merged
merged 3 commits into from
Sep 30, 2018
Merged

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented Sep 30, 2018

This was missed during #612 but is also indicative of #645.

@codecov
Copy link

codecov bot commented Sep 30, 2018

Codecov Report

Merging #646 into develop will increase coverage by 3.43%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #646      +/-   ##
===========================================
+ Coverage    65.64%   69.08%   +3.43%     
===========================================
  Files           66       65       -1     
  Lines         5792     5702      -90     
  Branches       810      798      -12     
===========================================
+ Hits          3802     3939     +137     
+ Misses        1780     1553     -227     
  Partials       210      210
Impacted Files Coverage Δ
pocs/serial_handlers/protocol_arduinosimulator.py 75.28% <0%> (-1.55%) ⬇️
peas/webcam.py
pocs/mount/simulator.py 92.79% <0%> (+1.8%) ⬆️
pocs/mount/mount.py 59.19% <0%> (+2.57%) ⬆️
pocs/utils/images/fits.py 82.95% <0%> (+3.97%) ⬆️
pocs/camera/camera.py 90% <0%> (+5.26%) ⬆️
pocs/camera/simulator.py 100% <0%> (+5.45%) ⬆️
pocs/images.py 91.81% <0%> (+7.27%) ⬆️
pocs/state/states/default/scheduling.py 66.66% <0%> (+8.33%) ⬆️
pocs/observatory.py 87.95% <0%> (+12.37%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e52c15a...21cd122. Read the comment docs.

@wtgee
Copy link
Member Author

wtgee commented Sep 30, 2018

That's the kind of test coverage bump I want...

@wtgee wtgee added the Quick PR This PR should be quick to review. label Sep 30, 2018
Copy link
Contributor

@jamessynge jamessynge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really tell what the effect of this change is.

@jamessynge
Copy link
Contributor

Though I do see that coverage has gone up by more than 1%. Pretty good!

Copy link
Contributor

@jamessynge jamessynge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because of the coverage increase alone, without fully understanding the impact.

Maybe add some comments in the new fixture?

@wtgee
Copy link
Member Author

wtgee commented Sep 30, 2018

Can't really tell what the effect of this change is.

This was merely a fix that should have been put in place with #612 (the camera dependency injection). Without this change the Observatory object is not getting passed any cameras so was erroring.

Which, now that I write that, means that we should have a check in the Observatory such that it cannot leave the ready state if there are no cameras attached. Edit: added #651

@wtgee wtgee merged commit b6749a7 into panoptes:develop Sep 30, 2018
@wtgee wtgee deleted the camera-di-tests branch September 30, 2018 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Quick PR This PR should be quick to review. Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants