Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autofocus Plots set to False #633

Merged
merged 1 commit into from
Sep 26, 2018
Merged

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented Sep 26, 2018

  • Setting autofocus plots to False by default.
  • Pass autofocus params straight through to underlying focuser.autofocus.

Closes #632

…ocus`.

* Setting autofocus plots to False by default.
@codecov
Copy link

codecov bot commented Sep 26, 2018

Codecov Report

Merging #633 into develop will decrease coverage by 0.66%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #633      +/-   ##
===========================================
- Coverage    67.89%   67.22%   -0.67%     
===========================================
  Files           65       65              
  Lines         5690     5690              
  Branches       798      798              
===========================================
- Hits          3863     3825      -38     
- Misses        1616     1655      +39     
+ Partials       211      210       -1
Impacted Files Coverage Δ
pocs/camera/camera.py 90% <ø> (ø) ⬆️
pocs/focuser/focuser.py 62.34% <ø> (-14.58%) ⬇️
pocs/observatory.py 76.55% <100%> (+0.59%) ⬆️
pocs/serial_handlers/protocol_arduinosimulator.py 75.28% <0%> (-1.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d0240f...5544295. Read the comment docs.

@wtgee wtgee merged commit 8056f46 into panoptes:develop Sep 26, 2018
@wtgee wtgee deleted the autofocus-plots-off-632 branch September 26, 2018 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants