Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out why test_autofocus_coarse hangs #632

Closed
wtgee opened this issue Sep 25, 2018 · 4 comments · Fixed by #696
Closed

Figure out why test_autofocus_coarse hangs #632

wtgee opened this issue Sep 25, 2018 · 4 comments · Fixed by #696
Assignees
Labels

Comments

@wtgee
Copy link
Member

wtgee commented Sep 25, 2018

The test_observatory.py test_autofocus_coarse is hanging on almost all branches some of the time. Often a restart of the test will fix it. Need to figure out what process is causing the problem.

@wtgee
Copy link
Member Author

wtgee commented Sep 25, 2018

Setting plots=False in the test files seems to do the trick. Still testing out some changes.

@wtgee
Copy link
Member Author

wtgee commented Sep 26, 2018

Note: I didn't figure out why this was happening, I just set it to skip for certain tests. Still need to figure out why so should probably leave open.

@wtgee wtgee reopened this Sep 26, 2018
@AnthonyHorton
Copy link
Collaborator

AnthonyHorton commented Sep 26, 2018

That is odd. Haven't had issues with this in the past. I have been seeing intermittent test failures in the Arduino tests, though.

This change to disable focus plots in the tests has broken the autofocus tests in my pyro-cameras branch as there I had expanded the tests to check for the presence of the plot files while I was working on the copying of files from remote cameras. I've re-enabled plotting in my branch for now, will keep an eye out for hanging tests.

@wtgee
Copy link
Member Author

wtgee commented Sep 26, 2018

That is odd. Haven't had issues with this in the past. I have been seeing intermittent test failures in the Arduino tests, though.

Something about the arduino simulator definitely does wacky things to our coverage.

This change to disable focus plots in the tests has broken the autofocus tests in my pyro-cameras branch as there I had expanded the tests to check for the presence of the plot files while I was working on the copying of files from remote cameras. I've re-enabled plotting in my branch for now, will keep an eye out for hanging tests.

It definitely could have been the result of my refactor and/or subsequent barrage of PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants