Clear existing offset info when parking #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bad log call
Codecov Report
@@ Coverage Diff @@
## develop #330 +/- ##
===========================================
+ Coverage 83.81% 83.81% +<.01%
===========================================
Files 51 51
Lines 3367 3368 +1
Branches 422 422
===========================================
+ Hits 2822 2823 +1
Misses 404 404
Partials 141 141
Continue to review full report at Codecov.
|
jamessynge
approved these changes
Jan 13, 2018
|
|
||
| pocs.next_state = 'parked' | ||
|
|
||
| if pocs.observatory.has_dome: | ||
| pocs.say('Closing dome') | ||
| if not pocs.observatory.close_dome(): | ||
| self.logger.critical('Unable to close dome!') | ||
| pocs.logger.critical('Unable to close dome!') |
There was a problem hiding this comment.
Doh! Thanks for catching that.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only an issue if the system temporarily parks because of bad weather then starts back up and selects the same target. Without this the mount will try to adjust tracking after taking a pointing picture.
Fix a bad log call