Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace file-relative imports with root-relative imports #252

Merged
merged 1 commit into from
Dec 25, 2017

Conversation

jamessynge
Copy link
Contributor

Add some imports to init.py files so that the root-relative imports of the typical AbstractBaseClass don't look like:
from pocs.foo.foo import AbstractFoo.
Fix a typo.

Add some imports to __init__.py files so that the root-relative
imports of the typical AbstractBaseClass doesn't look like:
   from pocs.foo.foo import AbstractFoo.
Fix a typo.
@jamessynge jamessynge requested a review from a team December 25, 2017 00:31
@codecov
Copy link

codecov bot commented Dec 25, 2017

Codecov Report

Merging #252 into develop will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #252      +/-   ##
===========================================
+ Coverage     79.8%   79.83%   +0.03%     
===========================================
  Files           42       46       +4     
  Lines         3204     3209       +5     
  Branches       415      415              
===========================================
+ Hits          2557     2562       +5     
  Misses         503      503              
  Partials       144      144
Impacted Files Coverage Δ
pocs/camera/__init__.py 100% <100%> (ø)
pocs/state/machine.py 88.73% <100%> (ø) ⬆️
pocs/mount/mount.py 57.01% <100%> (ø) ⬆️
pocs/camera/camera.py 92.13% <100%> (ø) ⬆️
pocs/mount/__init__.py 100% <100%> (ø)
pocs/scheduler/scheduler.py 94.68% <100%> (ø) ⬆️
pocs/camera/simulator.py 96.29% <100%> (ø) ⬆️
pocs/state/states/default/pointing.py 87.75% <100%> (ø) ⬆️
pocs/utils/rs232.py 93.61% <100%> (ø) ⬆️
pocs/focuser/focuser.py 79.06% <100%> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e390b99...859f207. Read the comment docs.

Copy link
Member

@wtgee wtgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for doing this.

@wtgee wtgee merged commit 9c23179 into panoptes:develop Dec 25, 2017
@jamessynge jamessynge deleted the issue-174-root-relative-imports branch January 1, 2018 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants