Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use root relative imports, not file or directory relative imports. #174

Closed
jamessynge opened this issue Dec 3, 2017 · 2 comments
Closed
Labels

Comments

@jamessynge
Copy link
Contributor

Per our discussion, we will use imports starting with pocs or peas, and will import packages and modules but not variables, classes and functions. For example:

import pocs
from pocs.utils import images

To avoid destroying our productivity, we should do this incrementally, perhaps as we modify files. In a while, we can go back and fix missed files.

@jamessynge
Copy link
Contributor Author

We should start with modifying CONTRIBUTING.md to describe this.

@wtgee wtgee added the Ongoing label Dec 5, 2017
@wtgee
Copy link
Member

wtgee commented Dec 27, 2017

#252 took care of most of these so I'm closing this issue. While we want to remain vigilant about making sure we do this going forward I'm not sure I want the Issue hanging around. Closing for now.

@wtgee wtgee closed this as completed Dec 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants