Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique job names for dictobjs #84

Closed
wants to merge 3 commits into from

Conversation

cisaacstern
Copy link
Member

WIP with @jbusecke for ensuring unique job names on dict obj deploys.

There are a few details to work out which I will comment on shortly.

@cisaacstern
Copy link
Member Author

xref pangeo-forge/deploy-recipe-action#17 with changes in action to accommodate this PR

@cisaacstern
Copy link
Member Author

Noting this PR changes the assumption of pangeo-forge/roadmap#49 regarding how dict objects should be declared in a meta.yaml.

We elected to do this because that assumption would prevent a single feedstock from containing multiple recipes representing a mix of dict objects and regular recipe objects, as demonstrated here:

Generally speaking it's probably not a good idea to just change these assumptions on-the-fly like this, and the roadmap repo linked above is long-since unmaintained, so I think the best path forward here is to first introduce the suggestion discussed starting in pangeo-forge/pangeo-forge-recipes#514 (comment) that https://github.com/pangeo-forge/meta-yaml-schema be consolidated into -runner. Once this is done, the changes to the meta yaml parsing assumptions added in this PR can be paired with a corresponding change to the meta yaml schema, which feels much more intelligible.

@cisaacstern
Copy link
Member Author

Generally speaking it's probably not a good idea to just change these assumptions on-the-fly like this, and the roadmap repo linked above is long-since unmaintained, so I think the best path forward here is to first introduce the suggestion discussed starting in pangeo-forge/pangeo-forge-recipes#514 (comment) that https://github.com/pangeo-forge/meta-yaml-schema be consolidated into -runner. Once this is done, the changes to the meta yaml parsing assumptions added in this PR can be paired with a corresponding change to the meta yaml schema, which feels much more intelligible.

@jbusecke, this is now being tracked in #93, would be great to have you take a look at this, as your current work is reliant on this.

@cisaacstern cisaacstern mentioned this pull request Nov 16, 2023
4 tasks
@cisaacstern cisaacstern self-assigned this Nov 16, 2023
cisaacstern added a commit that referenced this pull request Nov 17, 2023
cisaacstern added a commit that referenced this pull request Nov 20, 2023
@cisaacstern
Copy link
Member Author

Superseded by #139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants