Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement unique job names from #84 #139

Merged
merged 7 commits into from
Nov 20, 2023
Merged

Conversation

cisaacstern
Copy link
Member

Reimplements #84 because that PR was quite old and it seemed easier to re-do it rather than grapple with the thorny merge.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (90479ab) 96.31% compared to head (16a821a) 96.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   96.31%   96.36%   +0.04%     
==========================================
  Files          15       15              
  Lines         489      495       +6     
==========================================
+ Hits          471      477       +6     
  Misses         18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cisaacstern
Copy link
Member Author

cisaacstern commented Nov 18, 2023

Remaining TODO:

@cisaacstern cisaacstern added test-dataflow Add this label to PRs to trigger Dataflow integration test. test-flink Add this label to PRs to trigger Dataflow integration test. labels Nov 18, 2023
@cisaacstern cisaacstern merged commit 6cba6bc into main Nov 20, 2023
26 checks passed
This was referenced Nov 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-dataflow Add this label to PRs to trigger Dataflow integration test. test-flink Add this label to PRs to trigger Dataflow integration test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant