-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce dependencies #572
Merged
Merged
reduce dependencies #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronspring
commented
Mar 6, 2021
Codecov Report
@@ Coverage Diff @@
## master #572 +/- ##
==========================================
- Coverage 94.40% 94.04% -0.37%
==========================================
Files 54 54
Lines 5079 5022 -57
==========================================
- Hits 4795 4723 -72
- Misses 284 299 +15
Continue to review full report at Codecov.
|
…red into AS_reduce_dependencies
…red into AS_reduce_dependencies
aaronspring
commented
Mar 10, 2021
aaronspring
commented
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
reduce dependency packages:
requirements.txt will only contain important packages for installing and running QuickStart
Not core functionality such as esmf for regridding, eofs for rel entropy, esmtools for stats will have to be installed by the user, won’t be in requirements but will be in environments and hence tested, but try import
Closes #454, #526
To-Do List
Make
try install as xesmf is already. Then close. Add both in testing envs. Also strip those