Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce dependencies #572

Merged
merged 26 commits into from
Mar 10, 2021
Merged

reduce dependencies #572

merged 26 commits into from
Mar 10, 2021

Conversation

aaronspring
Copy link
Collaborator

@aaronspring aaronspring commented Mar 5, 2021

Description

reduce dependency packages:
requirements.txt will only contain important packages for installing and running QuickStart
Not core functionality such as esmf for regridding, eofs for rel entropy, esmtools for stats will have to be installed by the user, won’t be in requirements but will be in environments and hence tested, but try import

Closes #454, #526

To-Do List

Make

try install as xesmf is already. Then close. Add both in testing envs. Also strip those

requirements.txt Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 6, 2021

Codecov Report

Merging #572 (58d9fcb) into master (ae343e2) will decrease coverage by 0.36%.
The diff coverage is 90.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #572      +/-   ##
==========================================
- Coverage   94.40%   94.04%   -0.37%     
==========================================
  Files          54       54              
  Lines        5079     5022      -57     
==========================================
- Hits         4795     4723      -72     
- Misses        284      299      +15     
Impacted Files Coverage Δ
climpred/comparisons.py 99.04% <ø> (ø)
climpred/horizon.py 96.55% <ø> (ø)
climpred/smoothing.py 87.65% <ø> (ø)
climpred/tests/test_compute_dims.py 100.00% <ø> (ø)
climpred/tests/test_perfect_model_prediction.py 100.00% <ø> (ø)
climpred/tests/test_utils.py 98.68% <ø> (-0.21%) ⬇️
climpred/relative_entropy.py 80.73% <50.00%> (-1.96%) ⬇️
climpred/stats.py 85.05% <69.69%> (-8.17%) ⬇️
climpred/tests/test_relative_entropy.py 92.30% <77.77%> (-7.70%) ⬇️
climpred/checks.py 95.23% <81.81%> (-1.61%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73566ec...505b72f. Read the comment docs.

@aaronspring aaronspring marked this pull request as ready for review March 10, 2021 11:48
requirements.txt Outdated Show resolved Hide resolved
@aaronspring aaronspring merged commit 98ea010 into master Mar 10, 2021
@aaronspring aaronspring deleted the AS_reduce_dependencies branch March 10, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

strip requirements to minimum
1 participant