-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
strip requirements to minimum #454
Comments
Agreed on
Agreed on |
xesmf can also be optional. Then not needed in #471 |
The tests were breaking without it so need to make sure the smoothing tests only run when |
we could have xesmf as extras_require so they don’t get installed for every user. But still we could have climpred[complete/all] in which we add it and then also test it |
See https://github.com/pangeo-data/climpred/pull/471/files. Got rid of We can make |
current list and my related comments:
xesmf not on the list but needed for regridding in smoothing |
Can we close this @aaronspring ? |
I will further refine this in the next weeks, so dont close please. but we dont have any import errors anymore at least |
tqdm
can go awaycartopy
only needed for docs, not climpred as suchmpl
only needed for graphics, could be optionalmany other requirements could become extra, see xarray how they skip tests if something not installed
The text was updated successfully, but these errors were encountered: