Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: move df.to_sql to generic + update with new functionality #6598

Merged
merged 1 commit into from
Mar 16, 2014
Merged

SQL: move df.to_sql to generic + update with new functionality #6598

merged 1 commit into from
Mar 16, 2014

Conversation

jorisvandenbossche
Copy link
Member

Initial commit for this.

Questions:

  • To catch Panels (and raiseNotImplementedError), should I do this in sql.to_sql or in NDFrame.to_sql?
  • To support Series, I can just call to_frame on it. Is this OK?

And should add tests for this.

@jreback
Copy link
Contributor

jreback commented Mar 11, 2014

I would to this in sql.to_sql (then NDFrame.to_sql is pretty generic)

you can call to_frame on Series, sure

@jreback jreback added the SQL label Mar 11, 2014
@jreback jreback added this to the 0.14.0 milestone Mar 11, 2014
@jorisvandenbossche jorisvandenbossche mentioned this pull request Mar 12, 2014
Closed
17 tasks
@jorisvandenbossche
Copy link
Member Author

added tests

jorisvandenbossche added a commit that referenced this pull request Mar 16, 2014
@jorisvandenbossche
Merge pull request #6598 from jorisvandenbossche/sql-to_sql
e0058fb 
SQL: move df.to_sql to generic + update with new functionality
@jorisvandenbossche jorisvandenbossche merged commit e0058fb into pandas-dev:master Mar 16, 2014
@jorisvandenbossche jorisvandenbossche deleted the sql-to_sql branch March 16, 2014 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
IO SQL to_sql, read_sql, read_sql_query Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jorisvandenbossche @jreback