Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: sql support with SQLAlchemy - follow-up #6292

Closed
15 of 17 tasks
jorisvandenbossche opened this issue Feb 6, 2014 · 9 comments · Fixed by #7120
Closed
15 of 17 tasks

ENH: sql support with SQLAlchemy - follow-up #6292

jorisvandenbossche opened this issue Feb 6, 2014 · 9 comments · Fixed by #7120
Labels
Dtype Conversions Unexpected or buggy dtype conversions IO SQL to_sql, read_sql, read_sql_query Testing pandas testing functions or related to the test suite
Milestone

Comments

@jorisvandenbossche
Copy link
Member

#5950 is now merged! (Thanks to @mangecoeur)

But there were still some issue to flesh out/fix:

There is also a todo list in #4163, but I thought it is cleaner to start a new one (but maybe we should copy some over).
Complement the list if you think of others!

@tony
Copy link

tony commented Feb 8, 2014

@jorisvandenbossche: Is there a minimum sqlalchemy version this is targeting?

Edit: I see v0.8.1 (https://github.com/pydata/pandas/pull/5950/files#diff-f2202167afc438a107cf9f73ac4f9fb1R98).

It may be helpful to know if it's a requirement / recommendation. If it's a larger project and the sqlalchemy version is locked and Pandas can be upgraded, they may still want to know if it's possible for them to utilize this at an older version.

@jreback
Copy link
Contributor

jreback commented Feb 8, 2014

@tony this should work for pretty much all versions of SQLAlchemy; it uses mainly the connection features

@stonebig
Copy link
Contributor

stonebig commented Mar 5, 2014

Hello,

With the new sql interface, will the 'classic' DB2API still works with params of a sql being a dictionnary ?

typical example = "execute('SELECT * FROM ATABLE WHERE AFIELD=%(x)s', {'x':x})"

@TomAugspurger
Copy link
Contributor

I added 'read and write a MultiIndex' to the list.

I (finally) have a need to use SQL so I'm going to be using sqlalchemy and the new pandas sql stuff pretty extensively in the next few weeks. I'll report what I find. Doing a df.to_sql() with a MultiIndex was the first thing I tried.

@jorisvandenbossche
Copy link
Member Author

@TomAugspurger Super! Certainly report (and fix? :-) everything, bugs, annoyances, suggestions. There are still a lot of issue to report and fix.

@stonebig I think so. Would you be able to test it with?

@jreback
Copy link
Contributor

jreback commented May 5, 2014

@jorisvandenbossche

if you can move residual issues that are not likely to be closed in 0.14 to 0.14.1 (or later)

release notes / v0.14.0.txt needed as well

not pushing, but lmk when you think you are 'ready' enough on this

@jorisvandenbossche
Copy link
Member Author

@jreback I will try to finish some things of this thursday of friday. Is that OK?

@jreback
Copy link
Contributor

jreback commented May 5, 2014

sure

thxs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dtype Conversions Unexpected or buggy dtype conversions IO SQL to_sql, read_sql, read_sql_query Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants