DEPR: Make FutureWarning into DeprecationWarning for groupby.apply #56952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Groupby
Deprecate
|
We should get this in for 2.2 right? |
lithomas1
approved these changes
Jan 19, 2024
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
|
thanks @rhshadrach. |
23 tasks
lithomas1
pushed a commit
to lithomas1/pandas
that referenced
this pull request
Jan 19, 2024
…onWarning for groupby.apply
5 tasks
lithomas1
added a commit
that referenced
this pull request
Jan 19, 2024
#56964) * Backport PR #56952: DEPR: Make FutureWarning into DeprecationWarning for groupby.apply * Update test_groupby.py * fix finally? --------- Co-authored-by: Richard Shadrach <[email protected]>
3 tasks
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
…andas-dev#56952) * DEPR: Make FutureWarning into DeprecationWarning for groupby.apply * suppress extra warning when CoW warning mode --------- Co-authored-by: Joris Van den Bossche <[email protected]> Co-authored-by: Thomas Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Ref: #54950 (comment)
cc @jorisvandenbossche @phofl
In the event we don't release a 2.3, I am okay waiting to enforce this deprecation until 4.0. The only downside I see of doing so is having users keep the shim
include_groupsfor longer.