DEPR: fillna downcasting from object dtype #54261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mroeschke
added
Dtype Conversions
mroeschke
reviewed
Aug 1, 2023
| @@ -689,6 +689,7 @@ contains NAs, an exception will be generated: | |||
| However, these can be filled in using :meth:`~DataFrame.fillna` and it will work fine: | |||
|
|
|||
| .. ipython:: python | |||
| :okwarning: | |||
There was a problem hiding this comment.
Can this be changed to the future usage?
There was a problem hiding this comment.
wouldn't it be weird to have documented behavior that you cant actually get yet?
There was a problem hiding this comment.
Or rather, can this be changed to show the work-around? (Just trying to get ahead when we will have to change this example eventually)
There was a problem hiding this comment.
Fair enough, I'll take a look in a bit. (Pretty deep in the weeds in the extension tests ATM)
5 tasks
mroeschke
reviewed
Sep 1, 2023
Co-authored-by: Matthew Roeschke <[email protected]>
|
updated+green |
mroeschke
approved these changes
Sep 18, 2023
|
Thanks @jbrockmendel |
hedeershowk
pushed a commit
to hedeershowk/pandas
that referenced
this pull request
Sep 20, 2023
* DEPR: fillna downcasting from object dtype * GH ref * suppress warning * update test * Update doc/source/whatsnew/v2.1.0.rst Co-authored-by: Matthew Roeschke <[email protected]> --------- Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.