-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPR: downcasting in NDFrame.where, mask, clip #53656
Conversation
@rhshadrach thoughts here? |
+1 on the future behavior. Agree this is a good candidate for a Edit: I forgot this was impacting multiple methods. That makes me favor the option rather than argument quite a bit more. |
@mroeschke @MarcoGorelli on board for implementing the future option here? |
yeah sounds good to me! |
is that something you want to do as part of this PR? |
I was planning to, yes. But if people were OK on doing this deprecation without a "do X instead" id also be happy do move forward as is |
@mroeschke thoughts here? im making a push to deprecate all our remaining silent downcasting and this is the hard one i think. im OK either to do this without a "do X instead" or to implement a "future" option. |
I think being more conservative with a future option would be better here since there seem to be no current way to work around this warning. |
Thanks @jbrockmendel |
* DEPR: downcasting in NDFrame.where, mask, clip * GH ref * suppress warning in doctet * add caller * implement future.no_silent_downcasting * move whatsnew to 2.2
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.Related to #40988.
This doesn't have a good "do X to avoid the warning/get the future behavior". Could be a use case for the "future" option from #53025
Alternative to #53108