-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: reindex with expansion and non-nanosecond dtype #53505
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
53edccc
BUG: reindex with expansion and non-nanosecond dtype
mroeschke 9c619db
Merge remote-tracking branch 'upstream/main' into bug/nonnano/expansion
mroeschke f084b1b
Restrict to timelike types
mroeschke f362c20
Check earlier
mroeschke cb2799c
Merge remote-tracking branch 'upstream/main' into bug/nonnano/expansion
mroeschke b4f2bec
handle NA
mroeschke 381bbde
Merge remote-tracking branch 'upstream/main' into bug/nonnano/expansion
mroeschke 5b7ed24
handle NA
mroeschke 2d42813
Better check
mroeschke b67f4aa
Merge remote-tracking branch 'upstream/main' into bug/nonnano/expansion
mroeschke 6515f3f
Merge remote-tracking branch 'upstream/main' into bug/nonnano/expansion
mroeschke 821cf5c
Merge remote-tracking branch 'upstream/main' into bug/nonnano/expansion
mroeschke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems fine, but is making me wonder if we should remove the caching on maybe_promote
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears this was done for performance reasons(?), but it certainly makes this a little more complex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
definitely for perf reasons, im pretty sure for ArrayManager