BUG: reindex with expansion and non-nanosecond dtype #53505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Missing-data
| try: | ||
| orig_is_nat = np.isnat(fill_value) | ||
| except TypeError: | ||
| pass |
There was a problem hiding this comment.
this seems fine, but is making me wonder if we should remove the caching on maybe_promote
There was a problem hiding this comment.
It appears this was done for performance reasons(?), but it certainly makes this a little more complex
There was a problem hiding this comment.
definitely for perf reasons, im pretty sure for ArrayManager
jbrockmendel
approved these changes
Jun 17, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jun 20, 2023
mroeschke
added a commit
that referenced
this pull request
Jun 20, 2023
…on-nanosecond dtype) (#53748) Backport PR #53505: BUG: reindex with expansion and non-nanosecond dtype Co-authored-by: Matthew Roeschke <[email protected]>
canthonyscott
pushed a commit
to canthonyscott/pandas-anthony
that referenced
this pull request
Jun 23, 2023
* BUG: reindex with expansion and non-nanosecond dtype * Restrict to timelike types * Check earlier * handle NA * handle NA * Better check
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* BUG: reindex with expansion and non-nanosecond dtype * Restrict to timelike types * Check earlier * handle NA * handle NA * Better check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modeis performed ontimedelta64dtype in pandas-2.0 #53497 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.