Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: Partially revert #29553 #51137

Merged
merged 4 commits into from
Feb 6, 2023
Merged

CLN: Partially revert #29553 #51137

merged 4 commits into from
Feb 6, 2023

Conversation

lithomas1
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@jbrockmendel
Copy link
Member

pandas/core/internals/blocks.py:683: error: Unused "type: ignore" comment

@jbrockmendel
Copy link
Member

I'll be happy to see this compat code go

@lithomas1 lithomas1 marked this pull request as ready for review February 5, 2023 23:41
jbrockmendel
jbrockmendel approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green

@mroeschke mroeschke added the Clean label Feb 6, 2023
@mroeschke mroeschke added this to the 2.0 milestone Feb 6, 2023
@mroeschke mroeschke merged commit 1efc2d7 into pandas-dev:main Feb 6, 2023
@mroeschke
Copy link
Member

Thanks @lithomas1

@lithomas1 lithomas1 deleted the cln-np-compat branch February 6, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@jbrockmendel jbrockmendel jbrockmendel approved these changes

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lithomas1 @jbrockmendel @mroeschke