Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snappy version #46347

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Fix snappy version #46347

merged 1 commit into from
Mar 15, 2022

Conversation

jonashaag
Copy link
Contributor

Fix for #46260

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@jonashaag
Copy link
Contributor Author

jonashaag commented Mar 12, 2022

Should we also add python-snappy to one of the CI envs?

@mroeschke
Copy link
Member

mroeschke commented Mar 12, 2022

Should we also add python-snappy to one of the CI envs?

Yes should be added to:

actions-38.yaml
actions-38-downstream_compat.yaml
actions-38-minimum_versions.yaml (pick latest as a pin)
actions-39.yaml
actions-310.yaml

And noted in install.rst (under compression section)

@jreback jreback added the CI Continuous Integration label Mar 12, 2022
@jreback jreback added this to the 1.5 milestone Mar 12, 2022
@jonashaag jonashaag force-pushed the fix-snappy-version branch from 6da73a7 to 030f028 Compare March 13, 2022 22:33
@@ -72,6 +73,10 @@ def get_version(module: types.ModuleType) -> str:
if module.__name__ == "brotli":
# brotli doesn't contain attributes to confirm it's version
return ""
if module.__name__ == "snappy":
# snappy doesn't contain attributes to confirm it's version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snappy.__version__ for me says "3.0.3"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you confusing it with https://snappy.math.uic.edu/?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good catch!

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for alphabetizing too. LGTM

@jreback jreback merged commit 7143c44 into pandas-dev:main Mar 15, 2022
@jreback
Copy link
Contributor

jreback commented Mar 15, 2022

thanks @jonashaag

simonjayhawkins pushed a commit to simonjayhawkins/pandas that referenced this pull request Mar 29, 2022
@simonjayhawkins simonjayhawkins modified the milestones: 1.5, 1.4.2 Mar 30, 2022
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants