Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add missing dependencies for skipped tests #46260

Merged
merged 8 commits into from
Mar 11, 2022

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Mar 8, 2022

@mroeschke mroeschke added the CI Continuous Integration label Mar 8, 2022
@jreback jreback added this to the 1.5 milestone Mar 8, 2022
@jreback jreback merged commit a49e0f5 into pandas-dev:main Mar 11, 2022
@mroeschke mroeschke deleted the ci/missing_deps branch March 12, 2022 01:21
@simonjayhawkins
Copy link
Member

@mroeschke On WSL am now seeing

======================================================= short test summary info =======================================================
FAILED pandas/tests/util/test_show_versions.py::test_show_versions - ImportError: Can't determine version for snappy
FAILED pandas/tests/util/test_show_versions.py::test_show_versions_console_json - ImportError: Can't determine version for snappy
FAILED pandas/tests/util/test_show_versions.py::test_show_versions_console - ImportError: Can't determine version for snappy
FAILED pandas/tests/util/test_show_versions.py::test_json_output_match - ImportError: Can't determine version for snappy
================== 4 failed, 161955 passed, 2224 skipped, 1414 xfailed, 23 xpassed, 43 warnings in 495.03s (0:08:15) ==================
_______________________________________________________ test_json_output_match ________________________________________________________
[gw5] linux -- Python 3.8.12 /home/simon/miniconda3/envs/pandas-dev/bin/python

capsys = <_pytest.capture.CaptureFixture object at 0x7fb2724e6640>
tmpdir = local('/tmp/pytest-of-simon/pytest-551/popen-gw5/test_json_output_match0')

    def test_json_output_match(capsys, tmpdir):
        # GH39701
>       pd.show_versions(as_json=True)

pandas/tests/util/test_show_versions.py:94: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
pandas/util/_print_versions.py:109: in show_versions
    deps = _get_dependency_info()
pandas/util/_print_versions.py:88: in _get_dependency_info
    mod = import_optional_dependency(modname, errors="ignore")
pandas/compat/_optional.py:149: in import_optional_dependency
    version = get_version(module_to_get)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

module = <module 'snappy' from '/home/simon/miniconda3/envs/pandas-dev/lib/python3.8/site-packages/snappy/__init__.py'>

    def get_version(module: types.ModuleType) -> str:
        version = getattr(module, "__version__", None)
        if version is None:
            # xlrd uses a capitalized attribute name
            version = getattr(module, "__VERSION__", None)
    
        if version is None:
            if module.__name__ == "brotli":
                # brotli doesn't contain attributes to confirm it's version
                return ""
>           raise ImportError(f"Can't determine version for {module.__name__}")
E           ImportError: Can't determine version for snappy

pandas/compat/_optional.py:75: ImportError

@simonjayhawkins
Copy link
Member

@mroeschke On WSL am now seeing

also seeing on ubuntu server

@jonashaag
Copy link
Contributor

intake/python-snappy#119

@jonashaag jonashaag mentioned this pull request Mar 12, 2022
4 tasks
simonjayhawkins pushed a commit to simonjayhawkins/pandas that referenced this pull request Mar 29, 2022
@simonjayhawkins simonjayhawkins modified the milestones: 1.5, 1.4.2 Mar 30, 2022
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants